[GitHub] [pulsar] coderzc commented on a diff in pull request #18801: [improve][broker] Add config `fsyncEnable` for `RocksdbMetadataStore`

[GitBox <gi...@apache.org>]

coderzc commented on code in PR #18801:
URL: https://github.com/apache/pulsar/pull/18801#discussion_r1044200247


##########
conf/standalone.conf:
##########
@@ -29,6 +29,11 @@ metadataStoreUrl=
 # Configuration file path for metadata store. It's supported by RocksdbMetadataStore and EtcdMetadataStore for now
 metadataStoreConfigPath=
 
+# Whether we should enable fsync for local metadata store. It's supported by RocksdbMetadataStore for now
+# If this flag is true, metadata writes will be slower.
+# If this flag is false, and the machine crashes, some recent metadata writes may be lost.
+# Note that if it is just the process that crashes (i.e., the machine does not reboot), no writes will be lost even if it is false.
+metadataFsyncEnabled=true

Review Comment:
   > > Or we can expose it until we need it.
   > 
   > +1, we should be more cautious about exposing more configs to users. I think we can keep the config of `MetadataStoreConfig` and remove the one in `ServiceConfiguration`. It would be enough to solve the unit test case.
   
   OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org