You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/02/19 15:17:32 UTC
groovy git commit: Trivial refactoring: remove pointless `if`
Repository: groovy
Updated Branches:
refs/heads/master 427d2f256 -> 5d5b590cd
Trivial refactoring: remove pointless `if`
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/5d5b590c
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/5d5b590c
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/5d5b590c
Branch: refs/heads/master
Commit: 5d5b590cdbbba90097d6e8e36115f9cfda391765
Parents: 427d2f2
Author: danielsun1106 <re...@hotmail.com>
Authored: Mon Feb 19 23:17:25 2018 +0800
Committer: danielsun1106 <re...@hotmail.com>
Committed: Mon Feb 19 23:17:25 2018 +0800
----------------------------------------------------------------------
.../groovy/classgen/asm/ClosureWriter.java | 42 ++++++++++----------
1 file changed, 20 insertions(+), 22 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/5d5b590c/src/main/java/org/codehaus/groovy/classgen/asm/ClosureWriter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/classgen/asm/ClosureWriter.java b/src/main/java/org/codehaus/groovy/classgen/asm/ClosureWriter.java
index 7c44599..22b8653 100644
--- a/src/main/java/org/codehaus/groovy/classgen/asm/ClosureWriter.java
+++ b/src/main/java/org/codehaus/groovy/classgen/asm/ClosureWriter.java
@@ -278,28 +278,26 @@ public class ClosureWriter {
for (Parameter param : localVariableParams) {
String paramName = param.getName();
ClassNode type = param.getType();
- if (true) {
- VariableExpression initialValue = new VariableExpression(paramName);
- initialValue.setAccessedVariable(param);
- initialValue.setUseReferenceDirectly(true);
- ClassNode realType = type;
- type = ClassHelper.makeReference();
- param.setType(ClassHelper.makeReference());
- FieldNode paramField = answer.addField(paramName, ACC_PRIVATE | ACC_SYNTHETIC, type, initialValue);
- paramField.setOriginType(ClassHelper.getWrapper(param.getOriginType()));
- paramField.setHolder(true);
- String methodName = Verifier.capitalize(paramName);
-
- // let's add a getter & setter
- Expression fieldExp = new FieldExpression(paramField);
- answer.addMethod(
- "get" + methodName,
- ACC_PUBLIC,
- realType.getPlainNodeReference(),
- Parameter.EMPTY_ARRAY,
- ClassNode.EMPTY_ARRAY,
- new ReturnStatement(fieldExp));
- }
+ VariableExpression initialValue = new VariableExpression(paramName);
+ initialValue.setAccessedVariable(param);
+ initialValue.setUseReferenceDirectly(true);
+ ClassNode realType = type;
+ type = ClassHelper.makeReference();
+ param.setType(ClassHelper.makeReference());
+ FieldNode paramField = answer.addField(paramName, ACC_PRIVATE | ACC_SYNTHETIC, type, initialValue);
+ paramField.setOriginType(ClassHelper.getWrapper(param.getOriginType()));
+ paramField.setHolder(true);
+ String methodName = Verifier.capitalize(paramName);
+
+ // let's add a getter & setter
+ Expression fieldExp = new FieldExpression(paramField);
+ answer.addMethod(
+ "get" + methodName,
+ ACC_PUBLIC,
+ realType.getPlainNodeReference(),
+ Parameter.EMPTY_ARRAY,
+ ClassNode.EMPTY_ARRAY,
+ new ReturnStatement(fieldExp));
}
}