You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by dj...@apache.org on 2007/03/12 18:39:53 UTC
svn commit: r517304 -
/geronimo/server/trunk/modules/geronimo-j2ee-builder/src/main/java/org/apache/geronimo/j2ee/deployment/annotation/HandlerChainAnnotationHelper.java
Author: djencks
Date: Mon Mar 12 10:39:52 2007
New Revision: 517304
URL: http://svn.apache.org/viewvc?view=rev&rev=517304
Log:
GERONIMO-2956 don't try to process class level HanlderChain annotations until we understand what they mean, if anything
Modified:
geronimo/server/trunk/modules/geronimo-j2ee-builder/src/main/java/org/apache/geronimo/j2ee/deployment/annotation/HandlerChainAnnotationHelper.java
Modified: geronimo/server/trunk/modules/geronimo-j2ee-builder/src/main/java/org/apache/geronimo/j2ee/deployment/annotation/HandlerChainAnnotationHelper.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-j2ee-builder/src/main/java/org/apache/geronimo/j2ee/deployment/annotation/HandlerChainAnnotationHelper.java?view=diff&rev=517304&r1=517303&r2=517304
==============================================================================
--- geronimo/server/trunk/modules/geronimo-j2ee-builder/src/main/java/org/apache/geronimo/j2ee/deployment/annotation/HandlerChainAnnotationHelper.java (original)
+++ geronimo/server/trunk/modules/geronimo-j2ee-builder/src/main/java/org/apache/geronimo/j2ee/deployment/annotation/HandlerChainAnnotationHelper.java Mon Mar 12 10:39:52 2007
@@ -103,17 +103,21 @@
private static void processHandlerChain(AnnotatedApp annotatedApp, ClassFinder classFinder) throws DeploymentException {
log.debug("processHandlerChain(): Entry: AnnotatedApp: " + annotatedApp.toString());
- List<Class> classeswithHandlerChain = classFinder.findAnnotatedClasses(HandlerChain.class);
+// List<Class> classeswithHandlerChain = classFinder.findAnnotatedClasses(HandlerChain.class);
List<Method> methodswithHandlerChain = classFinder.findAnnotatedMethods(HandlerChain.class);
List<Field> fieldswithHandlerChain = classFinder.findAnnotatedFields(HandlerChain.class);
- // Class-level annotation
- for ( Class cls : classeswithHandlerChain ) {
- HandlerChain handlerChain = (HandlerChain) cls.getAnnotation(HandlerChain.class);
- if ( handlerChain != null ) {
- addHandlerChain(annotatedApp, handlerChain, cls, null, null);
- }
- }
+// TODO: GERONIMO-2956
+// If we ultimately determine that handler chain annotations at a class-level do not need to be processed
+// in conjunction with any other annotations, which seems likely at this point, then these comments can be
+// removed
+// Class-level annotation
+// for ( Class cls : classeswithHandlerChain ) {
+// HandlerChain handlerChain = (HandlerChain) cls.getAnnotation(HandlerChain.class);
+// if ( handlerChain != null ) {
+// addHandlerChain(annotatedApp, handlerChain, cls, null, null);
+// }
+// }
// Method-level annotation
for ( Method method : methodswithHandlerChain ) {