You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/04 20:44:28 UTC

[GitHub] [spark] MaxGekk opened a new pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

MaxGekk opened a new pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457
 
 
   ### What changes were proposed in this pull request?
   In the PR, I propose to use the session local time zone defined by the SQL config `spark.sql.session.timeZone` instead of system JVM time zone in `DateTimeUtils.converTz`. In the case when those time zones are different, `convertTz` assumes wrongly that its input timestamp was parsed from local timestamp string using JVM time zone. Such assumption was correct in the past when timestamp strings were parsed by `java.sql.Timestamp.valueOf`. Currently, timestamp strings are converted to timestamp value via `CAST` which uses the session local time zone.
   
   ### Why are the changes needed?
   This fixes wrong behavior of the `to_utc_timestamp` and `from_utc_timestamp` function in the case when system JVM time zone is different from session time zone.
   
   ### Does this PR introduce any user-facing change?
   Yes, when session local time zone is different from system JVM time zone.
   
   ### How was this patch tested?
   Add new tests to `DateFunctionsSuite` for various JVM time zone, session time zone and to/from time zones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582146881
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22628/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#discussion_r375255895
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -65,6 +66,8 @@ object DateTimeUtils {
     TimeZone.getTimeZone(getZoneId(timeZoneId))
   }
 
+  def localTimeZone(): TimeZone = getTimeZone(SQLConf.get.sessionLocalTimeZone)
 
 Review comment:
   if it's test-only, can we put it in the test suites?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582397523
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117912/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582206626
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582428089
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582107582
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582137755
 
 
   **[Test build #117856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117856/testReport)** for PR 27457 at commit [`027923d`](https://github.com/apache/spark/commit/027923d903c2df146d92d54069e0aed5ea5ca4c1).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110831
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117855/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582557842
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582107041
 
 
   **[Test build #117855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117855/testReport)** for PR 27457 at commit [`9436787`](https://github.com/apache/spark/commit/94367878c1845af54a8d9a2f0907dd416aab0b6a).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582410324
 
 
   do we need to fix 2.4 as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582428111
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22701/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582206400
 
 
   **[Test build #117866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117866/testReport)** for PR 27457 at commit [`93949c0`](https://github.com/apache/spark/commit/93949c01727537f28366d5242d2ec9a8dde8501d).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110820
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582557842
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582206633
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117866/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582397516
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582428111
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22701/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582289490
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582289494
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22675/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582557847
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117938/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27457: [WIP][SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27457: [WIP][SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582598695
 
 
   I have add `[WIP]` because I have found an issue in the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582137865
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582428089
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582396760
 
 
   **[Test build #117912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117912/testReport)** for PR 27457 at commit [`49d67de`](https://github.com/apache/spark/commit/49d67dec90a517f34dab5146a74d047638e7c987).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582137873
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117856/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582397516
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#discussion_r375255551
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -65,6 +66,8 @@ object DateTimeUtils {
     TimeZone.getTimeZone(getZoneId(timeZoneId))
   }
 
+  def localTimeZone(): TimeZone = getTimeZone(SQLConf.get.sessionLocalTimeZone)
 
 Review comment:
   where do we call it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582146864
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582107582
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#discussion_r375255551
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -65,6 +66,8 @@ object DateTimeUtils {
     TimeZone.getTimeZone(getZoneId(timeZoneId))
   }
 
+  def localTimeZone(): TimeZone = getTimeZone(SQLConf.get.sessionLocalTimeZone)
 
 Review comment:
   where do we call it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110831
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117855/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582113141
 
 
   **[Test build #117856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117856/testReport)** for PR 27457 at commit [`027923d`](https://github.com/apache/spark/commit/027923d903c2df146d92d54069e0aed5ea5ca4c1).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110627
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582107587
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22617/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582137873
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117856/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110627
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582146864
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110637
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22618/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582557006
 
 
   **[Test build #117938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117938/testReport)** for PR 27457 at commit [`a74bf0f`](https://github.com/apache/spark/commit/a74bf0fa309586375b5ebdcf25b38ace4b37ee1d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class LegacyDateFormatter(pattern: String, locale: Locale) extends DateFormatter `
     * `class LegacyTimestampFormatter(`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582146881
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22628/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582289490
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582424538
 
 
   > do we need to fix 2.4 as well?
   
   Highly likely, yes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582288915
 
 
   **[Test build #117912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117912/testReport)** for PR 27457 at commit [`49d67de`](https://github.com/apache/spark/commit/49d67dec90a517f34dab5146a74d047638e7c987).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582146356
 
 
   **[Test build #117866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117866/testReport)** for PR 27457 at commit [`93949c0`](https://github.com/apache/spark/commit/93949c01727537f28366d5242d2ec9a8dde8501d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582288915
 
 
   **[Test build #117912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117912/testReport)** for PR 27457 at commit [`49d67de`](https://github.com/apache/spark/commit/49d67dec90a517f34dab5146a74d047638e7c987).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #27457: [WIP][SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #27457: [WIP][SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110820
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582206626
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582107587
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22617/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk edited a comment on issue #27457: [WIP][SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on issue #27457: [WIP][SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582598695
 
 
   I have added `[WIP]` because I have found an issue in the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582137865
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582557847
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117938/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582427450
 
 
   **[Test build #117938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117938/testReport)** for PR 27457 at commit [`a74bf0f`](https://github.com/apache/spark/commit/a74bf0fa309586375b5ebdcf25b38ace4b37ee1d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582397523
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117912/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582107041
 
 
   **[Test build #117855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117855/testReport)** for PR 27457 at commit [`9436787`](https://github.com/apache/spark/commit/94367878c1845af54a8d9a2f0907dd416aab0b6a).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110795
 
 
   **[Test build #117855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117855/testReport)** for PR 27457 at commit [`9436787`](https://github.com/apache/spark/commit/94367878c1845af54a8d9a2f0907dd416aab0b6a).
    * This patch **fails Java style tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582289494
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22675/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582206633
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117866/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#discussion_r375255895
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -65,6 +66,8 @@ object DateTimeUtils {
     TimeZone.getTimeZone(getZoneId(timeZoneId))
   }
 
+  def localTimeZone(): TimeZone = getTimeZone(SQLConf.get.sessionLocalTimeZone)
 
 Review comment:
   if it's test-only, can we put it in the test suites?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582110637
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22618/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582113141
 
 
   **[Test build #117856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117856/testReport)** for PR 27457 at commit [`027923d`](https://github.com/apache/spark/commit/027923d903c2df146d92d54069e0aed5ea5ca4c1).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582146356
 
 
   **[Test build #117866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117866/testReport)** for PR 27457 at commit [`93949c0`](https://github.com/apache/spark/commit/93949c01727537f28366d5242d2ec9a8dde8501d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27457: [SPARK-30730][SQL] Fix wrong assumption of `DateTimeUtils.converTz`
URL: https://github.com/apache/spark/pull/27457#issuecomment-582427450
 
 
   **[Test build #117938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117938/testReport)** for PR 27457 at commit [`a74bf0f`](https://github.com/apache/spark/commit/a74bf0fa309586375b5ebdcf25b38ace4b37ee1d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org