You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2016/07/12 06:54:56 UTC

[GitHub] incubator-eagle pull request #265: EAGLE-372: Change AlertNotificationEntity...

GitHub user qingwen220 opened a pull request:

    https://github.com/apache/incubator-eagle/pull/265

    EAGLE-372: Change AlertNotificationEntity#fields type from String to List

    https://issues.apache.org/jira/browse/EAGLE-372
    
    We should avoid using String to express complex type in the entity definition. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qingwen220/incubator-eagle EAGLE-372

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----
commit 582102f2de5bd4b66d314de600838d2885ffba50
Author: Zhao, Qingwen <qi...@ebay.com>
Date:   2016-07-12T06:43:31Z

    change AlertNotificationEntity#fields type

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #265: EAGLE-372: Change AlertNotificationEntity#fields...

Posted by zombieJ <gi...@git.apache.org>.

Github user zombieJ commented on the issue:

    https://github.com/apache/incubator-eagle/pull/265
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #265: EAGLE-372: Change AlertNotificationEntity...

Posted by qingwen220 <gi...@git.apache.org>.

Github user qingwen220 closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---