You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/09/17 20:54:36 UTC
Review Request 38468: docs: Added discussion of finding a shepherd.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Repository: mesos
Description
-------
Added suggestion that new contributors seek to find a shepherd for their work
before their begin writing code. Made a few other improvements.
Diffs
-----
docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review100507
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38468]
All tests passed.
- Mesos ReviewBot
On Sept. 24, 2015, 9:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 9:29 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review101057
-----------------------------------------------------------
Ship it!
Still looks good. I'll commit this now.
docs/submitting-a-patch.md (line 63)
<https://reviews.apache.org/r/38468/#comment158370>
There is no MESOS-01, only MESOS-1.
- Adam B
On Sept. 29, 2015, 11:19 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 11:19 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
> Viewed markdown with https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review101004
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38468]
All tests passed.
- Mesos ReviewBot
On Sept. 29, 2015, 6:19 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 6:19 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
> Viewed markdown with https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 6:19 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
-------
Address review suggestions.
Repository: mesos
Description
-------
Added suggestion that new contributors seek to find a shepherd for their work
before their begin writing code. Made a few other improvements.
Diffs (updated)
-----
docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing (updated)
-------
Viewed markdown with https://github.com/mesosphere/mesos-website-container
Thanks,
Neil Conway
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review100671
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 24, 2015, 2:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 2:29 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review100934
-----------------------------------------------------------
Ship it!
This looks great! Thanks for the clarifications. I have a few suggestions, and if you're willing to integrate them, I'll go ahead and get this committed.
Also, I notice your "Testing Done" section is blank. ;) Did you try rendering this patch to see if the lists/indents still render properly? I strongly recommend using https://github.com/mesosphere/mesos-website-container
docs/submitting-a-patch.md (line 18)
<https://reviews.apache.org/r/38468/#comment158202>
Let's add a link to a query filtered to only Accepted issues.
https://issues.apache.org/jira/browse/MESOS-1?jql=project%20%3D%20MESOS%20AND%20status%20%3D%20Accepted
And mention the 'newbie' label, in case they want a good starter task.
https://issues.apache.org/jira/browse/MESOS-1?jql=project%20%3D%20MESOS%20AND%20status%20%3D%20Accepted%20AND%20labels%20%3D%20newbie
docs/submitting-a-patch.md (line 45)
<https://reviews.apache.org/r/38468/#comment158203>
Note that running mesos-tests does not recompile the tests, so you may want to first run `GTEST_FILTER="" make check` to recompile the tests without running any tests.
docs/submitting-a-patch.md (line 64)
<https://reviews.apache.org/r/38468/#comment158204>
While we're at it, let's add a recommendation for "Testing Done":
11. Under "Testing Done", explain what new tests you have created, what tests were modified, and what procedures you went through to test your changes.
- Adam B
On Sept. 24, 2015, 2:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 2:29 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/
-----------------------------------------------------------
(Updated Sept. 24, 2015, 9:29 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Added suggestion that new contributors seek to find a shepherd for their work
before their begin writing code. Made a few other improvements.
Diffs (updated)
-----
docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review99452
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38468]
All tests passed.
- Mesos ReviewBot
On Sept. 17, 2015, 9:28 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 9:28 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review99456
-----------------------------------------------------------
LGTM, thanks for doing this, Neil!
- Artem Harutyunyan
On Sept. 17, 2015, 2:28 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 2:28 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/
-----------------------------------------------------------
(Updated Sept. 17, 2015, 9:28 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Repository: mesos
Description
-------
Added suggestion that new contributors seek to find a shepherd for their work
before their begin writing code. Made a few other improvements.
Diffs (updated)
-----
docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review99424
-----------------------------------------------------------
Just a few comments related to what I picked up from the sync.
docs/submitting-a-patch.md (line 17)
<https://reviews.apache.org/r/38468/#comment156315>
Can you also add a note about preferring "Accepted" issues rather than "Open" issues?
docs/submitting-a-patch.md (line 62)
<https://reviews.apache.org/r/38468/#comment156316>
Can you add a line here about adding the shepherd to the list of reviewers?
docs/submitting-a-patch.md (line 64)
<https://reviews.apache.org/r/38468/#comment156318>
This line should probably be amended, since we don't want the behavior of wait-until-someone-picks-up-this-review.
You can mention something about pinging (pushing?) the shepherd to do the review, rather than the other way around.
- Joseph Wu
On Sept. 17, 2015, 11:54 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 11:54 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review99440
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38468]
All tests passed.
- Mesos ReviewBot
On Sept. 17, 2015, 6:54 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 6:54 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38468: docs: Added discussion of finding a
shepherd.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review99427
-----------------------------------------------------------
docs/reporting-a-bug.md (line 11)
<https://reviews.apache.org/r/38468/#comment156322>
I would actually recommend that newbies assign a ticket *after* they find a shepherd. Reduces the noise of people assigning tickets and unassigning when they realize it's out of scope, hard, etc.
docs/submitting-a-patch.md (line 26)
<https://reviews.apache.org/r/38468/#comment156321>
or asking on the JIRA ticket itself.
- Vinod Kone
On Sept. 17, 2015, 6:54 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 6:54 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>