You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "acezen (via GitHub)" <gi...@apache.org> on 2024/09/05 02:24:34 UTC
[PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
acezen opened a new pull request, #621:
URL: https://github.com/apache/incubator-graphar/pull/621
<!--
Thanks for contributing to GraphAr.
If this is your first pull request you can find detailed information on [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md)
The Apache GraphAr (incubating) community has restrictions on the naming of pr title. You can find instructions in
[CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md#title) too.
-->
### Reason for this PR
<!--
Why are you proposing this change? If this is already tracked in an issue, please link to the issue here.
Explaining clearly why this change is beneficial is important for the reviewers to understand the context.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **BREAKING CHANGE: <description>** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either
(a) a security vulnerability,
(b) a bug that caused incorrect or invalid data to be produced, or
(c) a bug that causes a crash (even when the API contract is upheld).
We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **Critical Fix: <description>** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "jasinliu (via GitHub)" <gi...@apache.org>.
jasinliu commented on code in PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621#discussion_r1749503968
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -107,11 +108,11 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "12.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
- message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
- endif ()
+ set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
+ # message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
+ # endif ()
set(GAR_ARROW_SOURCE_FILE "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz")
Review Comment:
> > If the user has their own download link, they can identify and determine the version after installation.
> > > Can environment variables or parameters be passed here?
>
> and I not sure what you mean own download link? you mean there maybe arrow that modified by user?
For example, the specified mirror link， the modification of the arrow，or some test version of the arrow. Custom links can provide some flexibility。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "acezen (via GitHub)" <gi...@apache.org>.
acezen commented on code in PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621#discussion_r1751133789
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -107,11 +108,11 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "12.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
- message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
- endif ()
+ set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
+ # message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
+ # endif ()
set(GAR_ARROW_SOURCE_FILE "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz")
Review Comment:
> > > If the user has their own download link, they can identify and determine the version after installation.
> > > > Can environment variables or parameters be passed here?
> >
> >
> > and I not sure what you mean own download link? you mean there maybe arrow that modified by user?
>
> For example, the specified mirror link， the modification of the arrow，or some test version of the arrow. Custom links can provide some flexibility。
But we are supposed to only support the original version of arrow, provide a link for that is a little weird. I suggest we still use the link from apache, and if user want to use other link, he could modify the cmake file directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "jasinliu (via GitHub)" <gi...@apache.org>.
jasinliu commented on code in PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621#discussion_r1746628231
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -107,11 +108,11 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "12.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
- message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
- endif ()
+ set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
+ # message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
+ # endif ()
set(GAR_ARROW_SOURCE_FILE "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz")
Review Comment:
If the user has their own download link, they can identify and determine the version after installation.
> Can environment variables or parameters be passed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "jasinliu (via GitHub)" <gi...@apache.org>.
jasinliu commented on code in PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621#discussion_r1746623906
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -107,11 +108,11 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "12.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
- message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
- endif ()
+ set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
+ # message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
+ # endif ()
set(GAR_ARROW_SOURCE_FILE "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz")
Review Comment:
Can environment variables or parameters be passed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "acezen (via GitHub)" <gi...@apache.org>.
acezen merged PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "acezen (via GitHub)" <gi...@apache.org>.
acezen commented on code in PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621#discussion_r1749501619
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -107,11 +108,11 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "12.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
- message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
- endif ()
+ set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
+ # message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
+ # endif ()
set(GAR_ARROW_SOURCE_FILE "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz")
Review Comment:
> If the user has their own download link, they can identify and determine the version after installation.
>
> > Can environment variables or parameters be passed here?
and I not sure what you mean own download link? you mean there maybe arrow that modified by user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat(c++): recover the BUILD_ARROW_FROM_SOURCE option [incubator-graphar]
Posted by "acezen (via GitHub)" <gi...@apache.org>.
acezen commented on code in PR #621:
URL: https://github.com/apache/incubator-graphar/pull/621#discussion_r1749500964
##########
cpp/cmake/apache-arrow.cmake:
##########
@@ -107,11 +108,11 @@ function(build_arrow)
find_package(Threads)
find_package(Arrow QUIET)
- set(ARROW_VERSION_TO_BUILD "12.0.0" CACHE INTERNAL "arrow version")
- if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
- message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
- set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
- endif ()
+ set(ARROW_VERSION_TO_BUILD "15.0.0" CACHE INTERNAL "arrow version")
+ # if (Arrow_FOUND) # arrow is installed, build the same version as the installed one
+ # message(STATUS "Found Arrow installed, align to version: ${Arrow_VERSION}")
+ # set(ARROW_VERSION_TO_BUILD "${Arrow_VERSION}" CACHE INTERNAL "arrow version")
+ # endif ()
set(GAR_ARROW_SOURCE_FILE "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_VERSION_TO_BUILD}/apache-arrow-${ARROW_VERSION_TO_BUILD}.tar.gz")
Review Comment:
hi, @jasinliu, thanks for the advice. Maybe we can not expose the variable to user, and if there is arrow installed in the system, we can align to the version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org