You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/06 23:37:43 UTC

[GitHub] [maven-surefire] domdomegg commented on pull request #320: [SUREFIRE-1851] Prevent NPE in SmartStackTraceParser

domdomegg commented on pull request #320:
URL: https://github.com/apache/maven-surefire/pull/320#issuecomment-704608299


   Many thanks for your review 🙌
   
   I believe I have made the required changes, including:
   - removing unnecessary `synchronized`
   - squashing the commits into one final commit (0505338)
   - moving the array list constructor past the if statement, and using `Collections.emptyList()` instead


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org