[GitHub] [arrow] jgehrcke commented on pull request #36195: MINOR: [CI]: Bump actions/setup-go from 3 to 4

["jgehrcke (via GitHub)" <gi...@apache.org>]

jgehrcke commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1600599390

   > Is there any reason we are raising an AssertionError here?
   
   Yes, this code is not supposed to execute in GHA for a non-main branch:
   https://github.com/apache/arrow/blob/e6221c45de7b4c675bcedfac9afb87f6a131dad9/ci/scripts/go_bench_adapt.py#L50
   
   ```
   else:
       # Assume that the environment is not GitHub Actions CI. Error out if that
       # assumption seems to be wrong.
       assert os.getenv("GITHUB_ACTIONS") is None
   
       # This is probably a local dev environment, for testing. In this case, it
       # does usually not make sense to provide commit information (not a
       # controlled CI environment). Explicitly keep `github_commit_info=None` to
       # reflect that (to not send commit information).
   ```
   
   In that sense I think the failure is expected and does / should not block merge. If the redness is a problem then we can also sys.exit(0) instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org