You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/03/06 12:59:53 UTC
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8742: ACT8945A: Correct DEBUGASSERT code error, plus tidy ups
pkarashchenko commented on code in PR #8742:
URL: https://github.com/apache/nuttx/pull/8742#discussion_r1126382056
##########
drivers/power/supply/act8945a.c:
##########
@@ -258,23 +258,32 @@
# define ACT8945A_LDO4_PULLDOWN 0
#endif
-#define ACT8945A_REG(_id, _vsel) \
+/* Ramp times are fixed for this regulator */
+
+#define ETIME_0 0
+#define ETIME_400 400
+#define ETIME_800 800
+
+#define ACT8945A_REG(_id, _vsel, _etime) \
[ACT8945A_##_id] = \
{ \
- .name = CONFIG_ACT8945A_##_id##_NAME, \
- .id = ACT8945A_##_id, \
.n_voltages = ACT8945A_NUM_VOLTAGES, \
.vsel_reg = ACT8945A_##_id##_##_vsel, \
.vsel_mask = ACT8945A_VSET_MASK, \
+ .name = CONFIG_ACT8945A_##_id##_NAME, \
+ .id = ACT8945A_##_id, \
.enable_reg = ACT8945A_##_id##_CONTROL, \
.enable_mask = ACT8945A_EN_MASK, \
- .boot_on = ACT8945A_##_id##_BOOT_ON, \
+ .enable_time = _etime, \
Review Comment:
```suggestion
.enable_time = (_etime), \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org