You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/10 02:53:38 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6403: sched/mqueue: configurable mqueue notification
anchao opened a new pull request, #6403:
URL: https://github.com/apache/incubator-nuttx/pull/6403
## Summary
sched/mqueue: configurable mqueue notification
## Impact
N/A
## Testing
mq_send performance test (cycle count)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6403: sched/mqueue: configurable mqueue notification
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6403:
URL: https://github.com/apache/incubator-nuttx/pull/6403#discussion_r894967135
##########
include/nuttx/mqueue.h:
##########
@@ -97,7 +97,9 @@ struct mqueue_inode_s
#else
uint16_t maxmsgsize; /* Max size of message in message queue */
#endif
+#ifndef CONFIG_DISABLE_MQUEUE_NOTIFICATION
pid_t ntpid; /* Notification: Receiving Task's PID */
+#endif
struct sigevent ntevent; /* Notification description */
struct sigwork_s ntwork; /* Notification work */
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6403: sched/mqueue: configurable mqueue notification
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6403:
URL: https://github.com/apache/incubator-nuttx/pull/6403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6403: sched/mqueue: configurable mqueue notification
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6403:
URL: https://github.com/apache/incubator-nuttx/pull/6403#discussion_r894815683
##########
include/nuttx/mqueue.h:
##########
@@ -97,7 +97,9 @@ struct mqueue_inode_s
#else
uint16_t maxmsgsize; /* Max size of message in message queue */
#endif
+#ifndef CONFIG_DISABLE_MQUEUE_NOTIFICATION
pid_t ntpid; /* Notification: Receiving Task's PID */
+#endif
struct sigevent ntevent; /* Notification description */
struct sigwork_s ntwork; /* Notification work */
Review Comment:
```suggestion
#ifndef CONFIG_DISABLE_MQUEUE_NOTIFICATION
pid_t ntpid; /* Notification: Receiving Task's PID */
struct sigevent ntevent; /* Notification description */
struct sigwork_s ntwork; /* Notification work */
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org