You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/11/13 17:23:30 UTC

Review Request 27993: Alerts: Remove All Nagios References From Agent Code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27993/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.


Bugs: AMBARI-8311
    https://issues.apache.org/jira/browse/AMBARI-8311


Repository: ambari


Description
-------

Removal of all references to Nagios in agent code base. Most of this was actually in the test scripts. In some places where we should retain test functionality, I changed the use of nagios to another service (like ganglia or yarn).


Diffs
-----

  ambari-agent/conf/unix/ambari-agent.ini fc76d0e 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ca2e80c 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 5e06ffa 
  ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 77c5253 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 874b4c9 
  ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py c659a03 
  ambari-agent/src/test/python/ambari_agent/TestCommandStatusDict.py 32df30b 
  ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py c958412 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 8cf9220 
  ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 9dfb47a 
  ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py 160b929 
  ambari-agent/src/test/python/ambari_agent/dummy_files/dummy_current_stack 7123c53 
  ambari-agent/src/test/python/ambari_agent/dummy_puppet_output_error2.txt 19ae347 
  ambari-agent/src/test/python/ambari_agent/dummy_puppet_output_error3.txt 5faf417 
  ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py a3163f4 

Diff: https://reviews.apache.org/r/27993/diff/


Testing
-------

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9.025 s
[INFO] Finished at: 2014-11-13T11:10:57-05:00
[INFO] Final Memory: 8M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Re: Review Request 27993: Alerts: Remove All Nagios References From Agent Code

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27993/#review61297
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Nov. 13, 2014, 4:23 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27993/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 4:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8311
>     https://issues.apache.org/jira/browse/AMBARI-8311
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removal of all references to Nagios in agent code base. Most of this was actually in the test scripts. In some places where we should retain test functionality, I changed the use of nagios to another service (like ganglia or yarn).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/ambari-agent.ini fc76d0e 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ca2e80c 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 5e06ffa 
>   ambari-agent/src/main/python/ambari_agent/StackVersionsFileHandler.py 77c5253 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 874b4c9 
>   ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py c659a03 
>   ambari-agent/src/test/python/ambari_agent/TestCommandStatusDict.py 32df30b 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py c958412 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 8cf9220 
>   ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 9dfb47a 
>   ambari-agent/src/test/python/ambari_agent/TestStackVersionsFileHandler.py 160b929 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/dummy_current_stack 7123c53 
>   ambari-agent/src/test/python/ambari_agent/dummy_puppet_output_error2.txt 19ae347 
>   ambari-agent/src/test/python/ambari_agent/dummy_puppet_output_error3.txt 5faf417 
>   ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py a3163f4 
> 
> Diff: https://reviews.apache.org/r/27993/diff/
> 
> 
> Testing
> -------
> 
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9.025 s
> [INFO] Finished at: 2014-11-13T11:10:57-05:00
> [INFO] Final Memory: 8M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>