You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/24 13:12:11 UTC
[GitHub] [beam] bullet03 opened a new pull request, #22841: [Website] add Python implementation to KinesisIO
bullet03 opened a new pull request, #22841:
URL: https://github.com/apache/beam/pull/22841
- add Python implementation to KinesisIO on https://beam.apache.org/documentation/io/connectors/
------------------------
before:
after:
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22841: [Website] add Python implementation to KinesisIO
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22841:
URL: https://github.com/apache/beam/pull/22841#issuecomment-1227492586
> Thank you!
Thank you for quick response!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22841: [Website] add Python implementation to KinesisIO
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22841:
URL: https://github.com/apache/beam/pull/22841#issuecomment-1226011096
@pcoet, could you, please help with review of current PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22841: [Website] add Python implementation to KinesisIO
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #22841:
URL: https://github.com/apache/beam/pull/22841#discussion_r954377506
##########
website/www/site/content/en/documentation/io/connectors.md:
##########
@@ -252,7 +252,10 @@ This table provides a consolidated, at-a-glance overview of the available built-
✔
<a href="https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/kinesis/KinesisIO.html">native</a>
</td>
- <td>Not available</td>
+ <td class="present">
+ ✔
+ <a href="https://beam.apache.org/releases/pydoc/current/apache_beam.io.kinesis.html#apache_beam.io.kinesis.ReadDataFromKinesis">native</a>
Review Comment:
This is actually exposed via cross-language: https://github.com/apache/beam/blob/ddfb6907288369bfc71c3a310cb9ceb717a4d3a0/sdks/python/apache_beam/io/kinesis.py#L196-L201
(note the "ExternalTransform")
```suggestion
<a href="https://beam.apache.org/releases/pydoc/current/apache_beam.io.kinesis.html#apache_beam.io.kinesis.ReadDataFromKinesis">via X-language</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on a diff in pull request #22841: [Website] add Python implementation to KinesisIO
Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #22841:
URL: https://github.com/apache/beam/pull/22841#discussion_r954655884
##########
website/www/site/content/en/documentation/io/connectors.md:
##########
@@ -252,7 +252,10 @@ This table provides a consolidated, at-a-glance overview of the available built-
✔
<a href="https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/kinesis/KinesisIO.html">native</a>
</td>
- <td>Not available</td>
+ <td class="present">
+ ✔
+ <a href="https://beam.apache.org/releases/pydoc/current/apache_beam.io.kinesis.html#apache_beam.io.kinesis.ReadDataFromKinesis">native</a>
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #22841: [Website] add Python implementation to KinesisIO
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #22841:
URL: https://github.com/apache/beam/pull/22841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22841: [Website] add Python implementation to KinesisIO
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22841:
URL: https://github.com/apache/beam/pull/22841#issuecomment-1227456903
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org