You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Xavier Lepaul (JIRA)" <ji...@apache.org> on 2011/04/11 22:03:05 UTC

[jira] [Created] (THRIFT-1139) C++ compilation of classes generated for an enum

C++ compilation of classes generated for an enum
------------------------------------------------

                 Key: THRIFT-1139
                 URL: https://issues.apache.org/jira/browse/THRIFT-1139
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 0.6
         Environment: OS : Windows XP, Compiler/IDE : Visual Studio 2008
            Reporter: Xavier Lepaul
            Priority: Minor


When using the patches from either THRIFT-1123 or THRIFT-1031, I get a compilation error when compiling the class generated for an enum type. The details are available in [this comment|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13017019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13017019].

I found that making {{apache::Thrift::TEnumIterator}} extend {{std::iterator<std::forward_iterator_tag, std::pair<int, const char*> >}} solve the issue, but I'm not able to test it on other platforms.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (THRIFT-1139) C++ compilation of classes generated for an enum

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1139.
---------------------------------

    Resolution: Fixed
      Assignee: Xavier Lepaul

just committed.
Thanks for the patch!

> C++ compilation of classes generated for an enum
> ------------------------------------------------
>
>                 Key: THRIFT-1139
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1139
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.6
>         Environment: OS : Windows XP, Compiler/IDE : Visual Studio 2008
>            Reporter: Xavier Lepaul
>            Assignee: Xavier Lepaul
>            Priority: Minor
>         Attachments: thrift-1139.patch
>
>
> When using the patches from either THRIFT-1123 or THRIFT-1031, I get a compilation error when compiling the class generated for an enum type. The details are available in [this comment|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13017019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13017019].
> I found that making {{apache::Thrift::TEnumIterator}} extend {{std::iterator<std::forward_iterator_tag, std::pair<int, const char*> >}} solve the issue, but I'm not able to test it on other platforms.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1139) C++ compilation of classes generated for an enum

Posted by "Xavier Lepaul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Lepaul updated THRIFT-1139:
----------------------------------

    Attachment: thrift-1139.patch

> C++ compilation of classes generated for an enum
> ------------------------------------------------
>
>                 Key: THRIFT-1139
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1139
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.6
>         Environment: OS : Windows XP, Compiler/IDE : Visual Studio 2008
>            Reporter: Xavier Lepaul
>            Priority: Minor
>         Attachments: thrift-1139.patch
>
>
> When using the patches from either THRIFT-1123 or THRIFT-1031, I get a compilation error when compiling the class generated for an enum type. The details are available in [this comment|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13017019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13017019].
> I found that making {{apache::Thrift::TEnumIterator}} extend {{std::iterator<std::forward_iterator_tag, std::pair<int, const char*> >}} solve the issue, but I'm not able to test it on other platforms.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1139) C++ compilation of classes generated for an enum

Posted by "Xavier Lepaul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021166#comment-13021166 ] 

Xavier Lepaul commented on THRIFT-1139:
---------------------------------------

I'm not able to checkout the source from svn ({{svn: access to '/repos/asf/thrift/trunk' forbidden}}). The attached patch is made against two local extractions of the [latest build from Jenking|https://builds.apache.org/hudson/job/Thrift/lastSuccessfulBuild/artifact/thrift/]

> C++ compilation of classes generated for an enum
> ------------------------------------------------
>
>                 Key: THRIFT-1139
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1139
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.6
>         Environment: OS : Windows XP, Compiler/IDE : Visual Studio 2008
>            Reporter: Xavier Lepaul
>            Priority: Minor
>         Attachments: thrift-1139.patch
>
>
> When using the patches from either THRIFT-1123 or THRIFT-1031, I get a compilation error when compiling the class generated for an enum type. The details are available in [this comment|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13017019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13017019].
> I found that making {{apache::Thrift::TEnumIterator}} extend {{std::iterator<std::forward_iterator_tag, std::pair<int, const char*> >}} solve the issue, but I'm not able to test it on other platforms.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1139) C++ compilation of classes generated for an enum

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021225#comment-13021225 ] 

Hudson commented on THRIFT-1139:
--------------------------------

Integrated in Thrift #130 (See [https://hudson.apache.org/hudson/job/Thrift/130/])
    THRIFT-1139 C++ compilation of classes generated for an enum
Patch: Xavier Lepaul


> C++ compilation of classes generated for an enum
> ------------------------------------------------
>
>                 Key: THRIFT-1139
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1139
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.6
>         Environment: OS : Windows XP, Compiler/IDE : Visual Studio 2008
>            Reporter: Xavier Lepaul
>            Assignee: Xavier Lepaul
>            Priority: Minor
>         Attachments: thrift-1139.patch
>
>
> When using the patches from either THRIFT-1123 or THRIFT-1031, I get a compilation error when compiling the class generated for an enum type. The details are available in [this comment|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13017019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13017019].
> I found that making {{apache::Thrift::TEnumIterator}} extend {{std::iterator<std::forward_iterator_tag, std::pair<int, const char*> >}} solve the issue, but I'm not able to test it on other platforms.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1139) C++ compilation of classes generated for an enum

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019000#comment-13019000 ] 

Roger Meier commented on THRIFT-1139:
-------------------------------------

could you please create a patch? see http://wiki.apache.org/thrift/HowToContribute


> C++ compilation of classes generated for an enum
> ------------------------------------------------
>
>                 Key: THRIFT-1139
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1139
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.6
>         Environment: OS : Windows XP, Compiler/IDE : Visual Studio 2008
>            Reporter: Xavier Lepaul
>            Priority: Minor
>
> When using the patches from either THRIFT-1123 or THRIFT-1031, I get a compilation error when compiling the class generated for an enum type. The details are available in [this comment|https://issues.apache.org/jira/browse/THRIFT-1031?focusedCommentId=13017019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13017019].
> I found that making {{apache::Thrift::TEnumIterator}} extend {{std::iterator<std::forward_iterator_tag, std::pair<int, const char*> >}} solve the issue, but I'm not able to test it on other platforms.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira