You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "agologan (via GitHub)" <gi...@apache.org> on 2025/07/14 17:27:41 UTC

[I] Playright included in final 5.0.0 image [superset]

agologan opened a new issue, #34161:
URL: https://github.com/apache/superset/issues/34161

   ### Bug description
   
   Looking at [5.0.0](https://hub.docker.com/r/apache/superset/tags?name=5.0.0) images these have increased in size compare to [4.1.x](https://hub.docker.com/r/apache/superset/tags?name=4.1) 892MB vs 292MB
   This seems to stem from the fact that this change #31385 moved playwright, gecko, chromium from the **dev image** into the **base image** which is then used for everything downstream. 
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "agologan (via GitHub)" <gi...@apache.org>.
agologan commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3072664052

   Afaik thumbnails are opt-in and it would represent a significant overhead in terms of image size and dependency management just to generate those.
   Can understand if the maintainers want to go in that direction but the change was not called out in the release notes and the few details I could dig up around it makes it seems it was not intentional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3097976882

   Note also that this MIGHT (but probably doesn't) intersect with @sadpandajoe's new SIP to use Playwright for E2E testing. Just noting it since Playwright is becoming a more established part of our little universe, and is growing roots!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3072441042

   One counterargument _might_ be that we're steering toward using Playwright for thumbnail generation. Would it make sense to leave it there for when that becomes the default configuration?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3070449239

   <!-- Greeting -->
   Hi @agologan! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m helping the superset team.
   
   <!-- Answer -->
   You’re not misunderstanding—Playwright is mainly for browser-based testing and automation, which does require Chromium or similar browsers. In the release workflow (tag-release.yml), neither Playwright nor Chromium is enabled or required by default. The relevant build args and environment variables (like INCLUDE_CHROMIUM) are set to false unless explicitly overridden, and the workflow itself doesn’t run browser-based tests or tasks that would need these dependencies. So, there’s no need to explicitly disable INCLUDE_CHROMIUM in the release workflow—it’s already off by default, and the release images shouldn’t include Chromium or Playwright unless you specifically opt in. The image size increase isn’t due to these components in the standard release workflow. If you’re seeing them included despite this, it might be worth double-checking for any custom overrides in your build environment.  
   Sources:  
   - [tag-release.yml workflow does not enable Chromium/Playwright](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/.github/workflows/tag-release.yml)  
   - [Default Docker env disables Playwright/Chromium](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/docker/.env)  
   - [docker-compose.yml defaults INCLUDE_CHROMIUM to false](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/docker-compose.yml)
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/7d31edb9-3503-4682-b9da-690f11ebfa22?feedback_type=other)</sup>&nbsp;&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[!
 [Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34161)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3089413719

   Good noticing and I appreciate you raising this for discussion. I wouldn't be opposed to bundling Playwright in the base image but I expect you're right that introducing it was an accident. Good call to ping @mistercrunch both as someone who touches these files and who has been committed to keeping the lean image lean. @mistercrunch is this something you think should be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch closed issue #34161: Playwright included in final 5.0.0 image
URL: https://github.com/apache/superset/issues/34161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3098026200

   Playwright should **not** be in the `lean` image. Let's fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Playwright included in final 5.0.0 image [superset]

Posted by "agologan (via GitHub)" <gi...@apache.org>.
agologan commented on issue #34161:
URL: https://github.com/apache/superset/issues/34161#issuecomment-3070440945

   @mistercrunch in the subsequent change #31386 `INCLUDE_CHROMIUM` was disabled for most dev workflows.
   Should've this been disabled for https://github.com/apache/superset/blob/master/.github/workflows/tag-release.yml#L95 workflow as well?
   Or am I misunderstanding the purpose of playwright?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org