You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/17 16:44:55 UTC
[GitHub] [druid] ccaominh opened a new pull request #10404: Remove max rows per segment from compaction dialog
ccaominh opened a new pull request #10404:
URL: https://github.com/apache/druid/pull/10404
### Description
Configuring auto compaction with single_dim partitioning in the web console, requires specifying `maxRowsPerSegment` in the "Tuning config" field, rather than the "Max rows per segment" field. Specifying `maxRowsPerSegment` in the "Tuning config" also works for dynamic and hash partitions. To make the workflow consistent for all partitioning schemes, remove the "Max rows per segment" field so that the value is always specified in the "Tuning config" field.
#### Before
#### After
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] added integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh closed pull request #10404: Remove max rows per segment from compaction dialog
Posted by GitBox <gi...@apache.org>.
ccaominh closed pull request #10404:
URL: https://github.com/apache/druid/pull/10404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh closed pull request #10404: Remove max rows per segment from compaction dialog
Posted by GitBox <gi...@apache.org>.
ccaominh closed pull request #10404:
URL: https://github.com/apache/druid/pull/10404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh edited a comment on pull request #10404: Remove max rows per segment from compaction dialog
Posted by GitBox <gi...@apache.org>.
ccaominh edited a comment on pull request #10404:
URL: https://github.com/apache/druid/pull/10404#issuecomment-697018403
Abandoning in favor of the improved compaction dialog UI added by https://github.com/apache/druid/pull/10417. I'll add the E2E tests in a different PR: https://github.com/apache/druid/pull/10425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on pull request #10404: Remove max rows per segment from compaction dialog
Posted by GitBox <gi...@apache.org>.
ccaominh commented on pull request #10404:
URL: https://github.com/apache/druid/pull/10404#issuecomment-697018403
Abandoning in favor of the improved compaction dialog UI added by https://github.com/apache/druid/pull/10417. I'll add the E2E tests in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on pull request #10404: Remove max rows per segment from compaction dialog
Posted by GitBox <gi...@apache.org>.
ccaominh commented on pull request #10404:
URL: https://github.com/apache/druid/pull/10404#issuecomment-697018403
Abandoning in favor of the improved compaction dialog UI added by https://github.com/apache/druid/pull/10417. I'll add the E2E tests in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org