You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/03/31 03:31:40 UTC

Review Request 32672: Extracting SLA group/algorithm generic interface.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32672/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-1220
    https://issues.apache.org/jira/browse/AURORA-1220


Repository: aurora


Description
-------

Refatoring SLA interfaces in preparation for job update related metrics (AURORA-1220).


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/sla/Algorithm.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/Group.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
  src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java a1d6c9d6857d2bacfcc7e4719ef2b42b66a9b470 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java d36f5652357e06d6c8944d907ee011b91e84e9c6 

Diff: https://reviews.apache.org/r/32672/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko


Re: Review Request 32672: Extracting SLA group/algorithm generic interface.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32672/#review78307
-----------------------------------------------------------

Ship it!


Master (3ab8a9e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 31, 2015, 1:31 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32672/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 1:31 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1220
>     https://issues.apache.org/jira/browse/AURORA-1220
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refatoring SLA interfaces in preparation for job update related metrics (AURORA-1220).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/sla/Algorithm.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/Group.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java a1d6c9d6857d2bacfcc7e4719ef2b42b66a9b470 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java d36f5652357e06d6c8944d907ee011b91e84e9c6 
> 
> Diff: https://reviews.apache.org/r/32672/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>