You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Web Development Guys (JIRA)" <ji...@apache.org> on 2009/03/04 15:11:56 UTC

[jira] Created: (CXF-2084) AbstractMessageResponseTimeInterceptor has protected methods, but default (package) scope constructor

AbstractMessageResponseTimeInterceptor has protected methods, but default (package) scope constructor
-----------------------------------------------------------------------------------------------------

                 Key: CXF-2084
                 URL: https://issues.apache.org/jira/browse/CXF-2084
             Project: CXF
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.1.4
            Reporter: Web Development Guys


The class org.apache.cxf.management.interceptor.AbstractMessageResponseTimeInterceptor has several protected methods, indicating a desire to allow extension; however, the class cannot be extended by a class outside the package org.apache.cxf.management.interceptor, because it has an explicit constructor with no scope modifier (and thus is accessible only within the package).

Presumably, this was an oversight, and the constructor should be protected, allowing clients of the API to extend the class.

Otherwise, the protected modifier should be removed from the methods within the class, since it is meaningless, and consideration should be given to making the class non-public, since it will be unusable by anything but CXF internals (this would depend on the existing package structure of CXF, with which I am not familiar).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-2084) AbstractMessageResponseTimeInterceptor has protected methods, but default (package) scope constructor

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2084.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.5
                   2.0.11
         Assignee: Daniel Kulp


Made the constructor public

> AbstractMessageResponseTimeInterceptor has protected methods, but default (package) scope constructor
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CXF-2084
>                 URL: https://issues.apache.org/jira/browse/CXF-2084
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.4
>            Reporter: Web Development Guys
>            Assignee: Daniel Kulp
>             Fix For: 2.0.11, 2.1.5
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The class org.apache.cxf.management.interceptor.AbstractMessageResponseTimeInterceptor has several protected methods, indicating a desire to allow extension; however, the class cannot be extended by a class outside the package org.apache.cxf.management.interceptor, because it has an explicit constructor with no scope modifier (and thus is accessible only within the package).
> Presumably, this was an oversight, and the constructor should be protected, allowing clients of the API to extend the class.
> Otherwise, the protected modifier should be removed from the methods within the class, since it is meaningless, and consideration should be given to making the class non-public, since it will be unusable by anything but CXF internals (this would depend on the existing package structure of CXF, with which I am not familiar).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.