You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "kpumuk (via GitHub)" <gi...@apache.org> on 2026/07/19 18:50:48 UTC
[PR] THRIFT-6103: Return unsigned values from Ruby MemoryBufferTransport [thrift]
kpumuk opened a new pull request, #3644:
URL: https://github.com/apache/thrift/pull/3644
<!-- Explain the changes in the pull request below: -->
The native `MemoryBufferTransport#read_byte` implementation returned signed values for bytes above `0x7f` because it stored the byte in a plain C `char`. The pure-Ruby implementation returns unsigned values, making direct raw-byte consumers depend on extension availability and platform representation.
The native transport now returns the same `0..255` byte values as the pure-Ruby implementation.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6103](https://issues.apache.org/jira/browse/THRIFT-6103)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6103: Return unsigned values from Ruby MemoryBufferTransport [thrift]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk merged PR #3644:
URL: https://github.com/apache/thrift/pull/3644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6103: Return unsigned values from Ruby MemoryBufferTransport [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3644:
URL: https://github.com/apache/thrift/pull/3644#issuecomment-5028070544
### Code review
No issues found. Checked for bugs, AGENTS.md compliance, and security implications.
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org