You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/28 00:05:15 UTC

[GitHub] [helix] narendly commented on a diff in pull request #2065: fix bug where generateJobList would iterate until the parallelism is reached

narendly commented on code in PR #2065:
URL: https://github.com/apache/helix/pull/2065#discussion_r860332884


##########
helix-core/src/main/java/org/apache/helix/task/RuntimeJobDag.java:
##########
@@ -198,11 +198,15 @@ public void generateJobList() {
     resetJobListAndDependencyMaps();
     computeIndependentNodes();
     _readyJobList.addAll(_independentNodes);
-    if (_isJobQueue && _readyJobList.size() > 0) {
+    if (_isJobQueue && !_readyJobList.isEmpty()) {

Review Comment:
   Little did I know! I think this is good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org