You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/02 14:22:56 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

wesm commented on a change in pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#discussion_r449037355



##########
File path: cpp/src/arrow/python/datetime.cc
##########
@@ -262,6 +265,42 @@ int64_t PyDate_to_days(PyDateTime_Date* pydate) {
                             PyDateTime_GET_DAY(pydate));
 }
 
+// GIL must be held when calling this function.
+Status StringToTzinfo(const std::string& tz, PyObject** tzinfo) {
+  static const std::regex kFixedOffset("([+-])(0[0-9]|1[0-9]|2[0-3]):([0-5][0-9])$");

Review comment:
       This won't work for gcc 4.8.x (which we still support)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org