You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/05 16:30:11 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
GutoVeronezi opened a new pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569
### Description
The bus type to `data disk` volumes is hardcoded to `virtio` or `scsi`, when using virtio-scsi (or, based on the template type). Therefore, there is no way to specify the bus type to data disk volumes (as we have for root disks).
This PR intends to replicate the `rootDiskController` behavior to `dataDiskController`, allowing the definition of the controller.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### How Has This Been Tested?
It has been tested locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-755441039
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-762233886
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-755419167
@RodrigoDLopez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-762497441
<b>Trillian test result (tid-3388)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32743 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4569-t3388-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-755418252
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-764586475
> one concern; the default used to be `virtio` and now it is `null`? otherwise the code looks good
@DaanHoogland
The method `getDataDiskModelFromVMDetail` returns null if the `dataDiskController` setting is not configured.
If the method returns null, then it will keep the same behavior as before, so the default still is `virtio`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-764586475
> one concern; the default used to be `virtio` and now it is `null`? otherwise the code looks good
@DaanHoogland
The method `getDataDiskModelFromVMDetail` returns null if the `dataDiskController` setting is not configured.
If the method returns null, then it will keep the same behavior as before, so the default still is `virtio`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-756276070
@RodrigoDLopez thanks for asking.
Actually the process is quite similar as which you described.
I made the whole process via GUI.
1. I created an instance.
2. With it stopped, I created a volume and attached to it.
3. I setted the `dataDiskController` setting as `ide` and started the instance.
4. After that, I checked if the detail informed was in the dump XML of the instance.
What I got was `<target dev = 'hda' bus = 'ide' />`, which was what I expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-762233511
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-765315120
@GutoVeronezi you are right, i read with crooked eyes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569#issuecomment-755445529
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org