[jira] [Commented] (CB-12293) The addPlugin function in Api.js assumes Gradle is used for build (patch introduced for Gradle in cordova-android version 6.0.0)

["Joe Bowser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795875#comment-15795875 ] 

Joe Bowser commented on CB-12293:
---------------------------------

So, does this actually break your build, or is this just an annoyance that slows it down?  I know that currently we're planning on making changes to Android to make it more compatible to Android Studio which includes deleting any remaining ANT compatibility, and I'm kind of surprised that ANT builds still work since there's been nobody maintaining them in the last couple of years.

> The addPlugin function in Api.js assumes Gradle is used for build (patch introduced for Gradle in cordova-android version 6.0.0)
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-12293
>                 URL: https://issues.apache.org/jira/browse/CB-12293
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0
>            Reporter: Sasa Bojanic
>
> The patch for Gradle in Api.js, addPlugin function assumes that Gradle is used for build.
> However, I'm using ant, in which case it unnecessarily downloads Gradle, etc...
> This issue is introduced in cordova-android version 6.0.0:
> return Q()
>        .then(function () {
>             //CB-11964: Do a clean when installing the plugin code to get around
>             //the Gradle bug introduced by the Android Gradle Plugin Version 2.2
>             //TODO: Delete when the next version of Android Gradle plugin comes out
>            // Since clean doesn't just clean the build, it also wipes out www, we need
>            // to pass additional options.
>            // Do some basic argument parsing
>             var opts = installOptions;//{"options":{"argv":["--ant"]}};
>             // Skip cleaning prepared files when not invoking via cordova CLI.
>             opts.noPrepare = true;
>             return self.clean(opts);
>         })
> ....



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org