You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/03/14 13:55:39 UTC
[GitHub] [openwhisk] InfamousPlatypus opened a new pull request #5200: Sent Quick Start's Java link to the JDK download location.
InfamousPlatypus opened a new pull request #5200:
URL: https://github.com/apache/openwhisk/pull/5200
## Description
Changed the Java link from the JRE page to the JDK page.
## Related issue and scope
#5199
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [X] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [X] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [X] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes. (I don't think this is needed for this?)
- [ ] My changes require further changes to the documentation.
- [X] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] mrutkows commented on a change in pull request #5200: Sent Quick Start's Java link to the JDK download location.
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #5200:
URL: https://github.com/apache/openwhisk/pull/5200#discussion_r829430896
##########
File path: README.md
##########
@@ -43,8 +43,8 @@ Learn more at [http://openwhisk.apache.org](http://openwhisk.apache.org).
The easiest way to start using OpenWhisk is to install the "Standalone" OpenWhisk stack.
This is a full-featured OpenWhisk stack running as a Java process for convenience.
-Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install),
-[Java](https://java.com/en/download/help/download_options.xml) and [Node.js](https://nodejs.org) available on your machine.
+Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install), the
+[Java Development Kit](https://www.oracle.com/java/technologies/downloads/) and [Node.js](https://nodejs.org) available on your machine.
Review comment:
Our policy is to reference OpenJDK as a basis and would also like to see a recommendation for a known, tested AdoptOpenJDK LTS version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] InfamousPlatypus commented on a change in pull request #5200: Sent Quick Start's Java link to the JDK download location.
Posted by GitBox <gi...@apache.org>.
InfamousPlatypus commented on a change in pull request #5200:
URL: https://github.com/apache/openwhisk/pull/5200#discussion_r835383227
##########
File path: README.md
##########
@@ -43,8 +43,8 @@ Learn more at [http://openwhisk.apache.org](http://openwhisk.apache.org).
The easiest way to start using OpenWhisk is to install the "Standalone" OpenWhisk stack.
This is a full-featured OpenWhisk stack running as a Java process for convenience.
-Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install),
-[Java](https://java.com/en/download/help/download_options.xml) and [Node.js](https://nodejs.org) available on your machine.
+Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install), the
+[Java Development Kit](https://www.oracle.com/java/technologies/downloads/) and [Node.js](https://nodejs.org) available on your machine.
Review comment:
I do have openJDK 11.0.11.9, it does not work and I don't know where it came from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] mrutkows commented on a change in pull request #5200: Sent Quick Start's Java link to the JDK download location.
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #5200:
URL: https://github.com/apache/openwhisk/pull/5200#discussion_r829430896
##########
File path: README.md
##########
@@ -43,8 +43,8 @@ Learn more at [http://openwhisk.apache.org](http://openwhisk.apache.org).
The easiest way to start using OpenWhisk is to install the "Standalone" OpenWhisk stack.
This is a full-featured OpenWhisk stack running as a Java process for convenience.
-Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install),
-[Java](https://java.com/en/download/help/download_options.xml) and [Node.js](https://nodejs.org) available on your machine.
+Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install), the
+[Java Development Kit](https://www.oracle.com/java/technologies/downloads/) and [Node.js](https://nodejs.org) available on your machine.
Review comment:
Our policy is to reference OpenJDK as a basis and would also like to see a recommendation for a known, tested AdoptOpenJDK LTS version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org