You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2010/03/28 16:27:44 UTC

DO NOT REPLY [Bug 49011] New: [PATCH] Speed up MD5 on Little Endian Machines

https://issues.apache.org/bugzilla/show_bug.cgi?id=49011

           Summary: [PATCH] Speed up MD5 on Little Endian Machines
           Product: APR
           Version: 1.3.9
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: APR-util
        AssignedTo: bugs@apr.apache.org
        ReportedBy: stefanfuhrmann@alice-dsl.de


Created an attachment (id=25199)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25199)
MD5 speedup patch

The patch attached eliminates unnecessary
buffer copy and clean-up operations on 
little-endian machines (e.g. x86 & friends).

Calling decode() will convert the buffer
'block' from little-endian to machine-endian
in 'x'. That is only necessary on big-endian
machines.

Net runtime savings: ~15%.

[[[
If we are on a little-endian machine, we
can read directly from the input buffer.

* crypto/apr_md5.c
  (MD5Transform): optmimize by translating 
  buffers & cleaning them up on big-endian
  machines only.

patch by stefanfuhrmann < at > alice-dsl.de
]]]

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 49011] [PATCH] Speed up MD5 on Little Endian Machines

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49011

--- Comment #3 from Stefan Fritsch <sf...@sfritsch.de> ---
1.5 commit: r1460281

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 49011] [PATCH] Speed up MD5 on Little Endian Machines

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49011

Stefan Fritsch <sf...@sfritsch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk

--- Comment #2 from Stefan Fritsch <sf...@sfritsch.de> ---
committed different version with alignment checks:
r1460244

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 49011] [PATCH] Speed up MD5 on Little Endian Machines

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49011

Stefan Fritsch <sf...@sfritsch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Stefan Fritsch <sf...@sfritsch.de> ---
fixed in 1.5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

DO NOT REPLY [Bug 49011] [PATCH] Speed up MD5 on Little Endian Machines

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49011

Stefan Fuhrmann <st...@alice-dsl.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

DO NOT REPLY [Bug 49011] [PATCH] Speed up MD5 on Little Endian Machines

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49011

--- Comment #1 from Stefan Fritsch <sf...@sfritsch.de> 2010-09-18 04:05:20 EDT ---
I don't think your patch is correct in general because block may be 1-byte
aligned but x must be 4-byte aligned. It would work on x86 but it may fail on
other architectures that don't support unaligned access.

One has to check the alignment and do a memcpy if the input block is not
properly aligned.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org