You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/06 08:51:29 UTC

[GitHub] [dubbo] Guiqu1aixi commented on pull request #10021: [ISSUE #10020] add MemorySafeLinkedBlockingQueue

Guiqu1aixi commented on PR #10021:
URL: https://github.com/apache/dubbo/pull/10021#issuecomment-1147205575

   我很困惑，为什么MemorySafeLinkedBlockingQueue#hasRemainedMemory()中要使用usage.getCommitted()与maxFreeMemory相比较。
   MemoryLimitCalculator后面又提供了两个方法分别是calculate 和 defaultLimit都是和当前jvm commited内存的比例相比较，这样可能更加科学一点，
   而hasRemainedMemory()直接使用当前commited相比较(第78行)，感觉并不能预防OOM。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org