You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/09/20 07:30:44 UTC
[GitHub] [kyuubi] pan3793 opened a new issue, #5314: Support JDK 21
pan3793 opened a new issue, #5314:
URL: https://github.com/apache/kyuubi/issues/5314
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
Java 21 and the JDK 21 release under a general availability (GA) status occurred a short time ago(Sep 19, 2023) as the newest major update to the Java programming language.
More details on today's Java 21 (JDK 21) GA release via the [JDK-dev mailing list](https://mail.openjdk.org/pipermail/jdk-dev/2023-September/008267.html). More details on all of the major improvements with Java 21 can be found via [OpenJDK.org](https://openjdk.org/projects/jdk/21/).
The current master/branch-1.8 supports Java 17, it would be nice if we could support Java 21 before 1.8.0 out.
### How should we improve?
Phase 1: test Kyuubi on JDK 21 and fix errors encountered
Phase 2: add CI in GitHub Actions
Phase 3(out of scope): leverage new features introduced in JDK 21, e.g. Virtual Thread
### Are you willing to submit PR?
- [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
- [ ] No. I cannot submit a PR at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "Tiakon (via GitHub)" <gi...@apache.org>.
Tiakon commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-1801468643
can i work on this issue? please assign me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed issue #5314: [TASK][EASY] Support JDK 21
URL: https://github.com/apache/kyuubi/issues/5314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "dupen01 (via GitHub)" <gi...@apache.org>.
dupen01 commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-2053907648
I have recently been tracking this issue and testing the behavior of JDK 21 locally on a branch. The biggest conflict arises from the version of `spotless-maven-plugin`.
The current version of `potless-maven-plugin` used in the master branch of the Kyuubi project is 2.30.0.
To support JDK 21, it is necessary to upgrade to a newer version, as per this issue: https://github.com/diffplug/spotless/issues/1819.
Correspondingly, the version of `googlejavaformat` also needs to be upgraded (currently, the Kyuubi project uses `googlejavaformat` v1.7, whereas the latest release of the `googlejavaformat` project is 1.22.0). This will cause some existing code formatting checks to fail.
Furthermore, if upgrading `spotless-maven-plugin` to a newer version, such as 2.43.0, in order to support JDK 21, it will result in the loss of support for JDK 1.8 (refer to: https://github.com/diffplug/spotless/blob/main/plugin-maven/README.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "dupen01 (via GitHub)" <gi...@apache.org>.
dupen01 commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-2055827219
I will submit a PR for this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "Tiakon (via GitHub)" <gi...@apache.org>.
Tiakon commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-1801498285
@pan3793 Thanks for reminding me, I will try to modify it and try to pass more tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-1801488648
@Tiakon some additional context, upgrading arrow to 13+ is required to support JDK 21, or we can disable all Arrow tests on JDK 21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-1801471160
@Tiakon thanks assigned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-2054326308
@dupen01 for cases you listed, seems could be addressed by overriding `properties` in `java-21` profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][EASY] Support JDK 21 [kyuubi]
Posted by "dupen01 (via GitHub)" <gi...@apache.org>.
dupen01 commented on issue #5314:
URL: https://github.com/apache/kyuubi/issues/5314#issuecomment-2053961628
Perhaps we could maintain the current version of the `spotless-maven-plugin` by skipping the spotless check process in a JDK 21 environment, just as the Apache Flink community has done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org