You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/02 15:43:22 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1689:
Fix bug : Use try-with-resources or close this "ResultSet" in a "finally"
clause
codecov-io commented on issue #1689: Fix bug : Use try-with-resources or close this "ResultSet" in a "finally" clause
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1689#issuecomment-570246069
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=h1) Report
> Merging [#1689](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/26ed786c4d4cd1b8ae0e49a4a2ac7f2677a1948a?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1689 +/- ##
========================================
- Coverage 16.3% 16.3% -0.01%
========================================
Files 283 283
Lines 13864 13869 +5
Branches 2251 2258 +7
========================================
Hits 2261 2261
- Misses 11343 11348 +5
Partials 260 260
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dolphinscheduler/dao/utils/PostgrePerformance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL1Bvc3RncmVQZXJmb3JtYW5jZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/dao/utils/MysqlPerformance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL015c3FsUGVyZm9ybWFuY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...org/apache/dolphinscheduler/dao/TaskRecordDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Rhc2tSZWNvcmREYW8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=footer). Last update [26ed786...45c54b0](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services