You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rohityadavcloud (via GitHub)" <gi...@apache.org> on 2025/03/28 07:37:53 UTC
[PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
rohityadavcloud opened a new pull request, #10630:
URL: https://github.com/apache/cloudstack/pull/10630
This removes extra slash from the base system url in Redfish oobm client utility.
Fixes #10441
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760465471
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10630?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.00%. Comparing base [(`5f93ce7`)](https://app.codecov.io/gh/apache/cloudstack/commit/5f93ce71bb9cbffb249cc058d64111ecc6be34ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`dda8a5f`)](https://app.codecov.io/gh/apache/cloudstack/commit/dda8a5f35d68084851bdab5694e8f412d74ad5d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (5f93ce7) and HEAD (dda8a5f). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (5f93ce7) | HEAD (dda8a5f) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #10630 +/- ##
=============================================
- Coverage 16.01% 4.00% -12.01%
=============================================
Files 5651 397 -5254
Lines 495858 32490 -463368
Branches 60048 5760 -54288
=============================================
- Hits 79407 1301 -78106
+ Misses 407590 31040 -376550
+ Partials 8861 149 -8712
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10630?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760605614
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760762641
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2804184244
@kiranchavala thanks for the logs, I've found and fixed the 'problem' code that read only the first line of the API response & not the content in its entirety due to which the JSON error happened. It's possible that real world refish bmcs don't have newlines in their json but the emulator does. Please help review/test it.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018081952
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s' requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
cc @wido @GabrielBrascher Line #263 is where I worry if not having a trailing slash `/` may break any redfish servers/bmcs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2808631390
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760456951
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811760576
Thanks @kiranchavala I double checked, I think the problem is in your setup. The error message wasn't clear so I've pushed a commit, it was actually sending a POST request but the emulator isn't supporting them. The default emulator mode is static and states here https://github.com/DMTF/Redfish-Interface-Emulator?tab=readme-ov-file#static-emulation-of-a-mockup that `In a static mock, only HTTP GETs will work`.
Now, the error will say this when it happens:
<img width="410" alt="Screenshot 2025-04-17 at 10 39 00 AM" src="https://github.com/user-attachments/assets/8150e4a5-d499-4c2b-acfc-66fedc431745" />
Using the emulator, the dynamic one seems to be supporting POST requests:
```
$ cp emulator-config_dynamic_populate.json emulator-config.json
$ python3 emulator.py -port 80
...
INFO:werkzeug:127.0.0.1 - - [17/Apr/2025 10:40:38] "POST /redfish/v1/Systems/System-1/Actions/ComputerSystem.Reset HTTP/1.1" 200 -
INFO:root:ComputerSystemCollectionAPI init called
INFO:root:ComputerSystemCollectionAPI GET called
...
```
Maybe could you also try/test against the sushy tools?
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018263413
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s' requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
ok, so do you mean we may have to spilt this case out into different ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811032237
<b>[SF] Trillian test result (tid-13014)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53064 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10630-t13014-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811761750
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760833700
<b>[SF] Trillian Build Failed (tid-12841)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760463266
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018266872
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s' requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
TBH, I don't know. Usually, I don't think we should require a trailing `/` (most servers should handle this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2813209237
> Please merge this as/when you may @Pearl1594 @DaanHoogland Thanks @kiranchavala for the extended testing. There's still a slight chance we have only tested against emulators, that some edge case was missed.
we cannot know/test against all hardware, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2804492387
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2812098940
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811728467
> Thanks @kiranchavala
>
> The issue 1 you've raised is a known problem as generally redfish is only on 443/https (when the global setting is on, it only works with 443/https). I've logged this issue for future fix #10742
>
> 2 is easily fixable but I don't know if it's a real-world issue or an issue with the emulator.
>
> @wido @GabrielBrascher do you remember or know if the redfish based servers you've, use GET or POST for actions (power operations including status checks)?
thanks @rohityadavcloud
According to the official redfish API reference guide , post request is used
pg 59 in
https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.6.0.pdf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811950942
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760464277
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811620185
Thanks @kiranchavala the issue #1 you've raised is a known problem as generally redfish is only on 443/https (when the global setting is on, it only works with 443/https). #2 is easily fixable but I don't know if it's a real-world issue or an issue with the emulator.
@wido @GabrielBrascher do you remember or know if the redfish based servers you've, use GET or POST for actions (power operations including status checks)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2812103008
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2814256928
<b>[SF] Trillian test result (tid-13032)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56642 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10630-t13032-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760755651
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760452008
Requesting @kiranchavala for any quick tips, review & tests. Also cc @Pearl1594 @DaanHoogland @andrijapanicsb @steveroles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018100689
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s' requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
so line 263 could read
```
return SYSTEMS_URL_PATH + "/";
```
o.r use File.SEPARATOR and/or String.format(). I think we should test it to make sure, but would not be a big issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018170524
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s' requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
No that's not what I meant - if for the basic discovery of the endpoint, a trailing slash isn't passed some systems could fail (hypothetically, I'm just asking). I couldn't return with the `/` as it breaks the base case per Kiran's findings (if I understood them right)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2760460778
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2808635712
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2811781822
Tested with:
1. [DTMF Redfish Emulator](https://github.com/DMTF/Redfish-Interface-Emulator) - with the dynamic profile, it worked except that the power state wouldn't change (something to do with the emulator itself).
2. [Sushy-tools fake emulator](https://github.com/openstack/sushy-tools/tree/master/sushy_tools/emulator) - it just worked out of the box and worked as expect, except for power cycle oobm command which it doesn't support:
```
[2025-04-17 10:56:08,318] DEBUG in main: Request failed with NotSupportedError: Power state PowerCycle is not supported
127.0.0.1 - - [17/Apr/2025 10:56:08] "POST /redfish/v1/Systems/27946b59-9e44-4fa7-8e91-f3527a1ef094/Actions/ComputerSystem.Reset HTTP/1.1" 500 -
in fake done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2813200166
Please merge this as/when you may @Pearl1594 @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] utils: fix extra slash in Redfish default systems url path [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#issuecomment-2804187906
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org