You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ptupitsyn (via GitHub)" <gi...@apache.org> on 2023/07/14 07:01:39 UTC
[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2317: IGNITE-19397 Return an error to client when outdated schema is used
ptupitsyn opened a new pull request, #2317:
URL: https://github.com/apache/ignite-3/pull/2317
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn merged pull request #2317: IGNITE-19397 Return an error to client when outdated schema is used
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #2317:
URL: https://github.com/apache/ignite-3/pull/2317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] isapego commented on a diff in pull request #2317: IGNITE-19397 Return an error to client when outdated schema is used
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego commented on code in PR #2317:
URL: https://github.com/apache/ignite-3/pull/2317#discussion_r1263486431
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -405,21 +408,25 @@ private void writeErrorCore(Throwable err, ClientMessagePacker packer) {
packer.packInt(INTERNAL_ERR);
}
+ // Class name and message.
packer.packString(err.getClass().getName());
+ packer.packString(err.getMessage());
Review Comment:
Argument of `packString` method should probably be marked as `@Nullable`. Or do we use those in Ignite 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2317: IGNITE-19397 Return an error to client when outdated schema is used
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #2317:
URL: https://github.com/apache/ignite-3/pull/2317#discussion_r1263505638
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -405,21 +408,25 @@ private void writeErrorCore(Throwable err, ClientMessagePacker packer) {
packer.packInt(INTERNAL_ERR);
}
+ // Class name and message.
packer.packString(err.getClass().getName());
+ packer.packString(err.getMessage());
Review Comment:
Fixed.
Yes, we [use @Nullable in Ignite 3](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2.1Commonannotatingrules).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org