You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/09/18 08:00:30 UTC

[kyuubi] branch master updated: [KYUUBI #5300] Batch v2 should not update kyuubi_instance when open session

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 413683507 [KYUUBI #5300] Batch v2 should not update kyuubi_instance when open session
413683507 is described below

commit 413683507079f8f97217e8099177f0b16bc9192d
Author: zwangsheng <bi...@apache.org>
AuthorDate: Mon Sep 18 16:00:21 2023 +0800

    [KYUUBI #5300] Batch v2 should not update kyuubi_instance when open session
    
    ### _Why are the changes needed?_
    
    See more in close #5300
    
    Remove update metadata kyuubi_instance, when open session under batch v2 implementation.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
    
    ### _Was this patch authored or co-authored using generative AI tooling?_
    
    No
    
    Closes #5301 from zwangsheng/server/v2_should_not_update_connect_url.
    
    Closes #5300
    
    0a67bcda1 [zwangsheng] [V2][REST] Not update kyuubi instace  when open session
    
    Authored-by: zwangsheng <bi...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala
index c8563bca1..e10230ebf 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala
@@ -156,7 +156,6 @@ class KyuubiBatchSession(
         // new batch job created using batch impl v2
         val metadataToUpdate = Metadata(
           identifier = initialMetadata.identifier,
-          kyuubiInstance = connectionUrl,
           requestName = name.orNull,
           requestConf = optimizedConf ++ kubernetesInfo, // save the kubernetes info
           clusterManager = batchJobSubmissionOp.builder.clusterManager())