[GitHub] stratos pull request: Fixed listing cartridge groups in cli

[dinusha-dilrukshi <gi...@git.apache.org>]

Github user dinusha-dilrukshi commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/379#discussion_r46131587
  
    --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java ---
    @@ -127,10 +127,10 @@ public static void addCartridge(CartridgeBean cartridgeBean) throws RestAPIExcep
                             cartridgeBean.getType()));
                 }
     
    -            for(PortMappingBean portMapping : cartridgeBean.getPortMapping()) {
    -                if(StringUtils.isBlank(portMapping.getName())) {
    +            for (PortMappingBean portMapping : cartridgeBean.getPortMapping()) {
    +                if (StringUtils.isBlank(portMapping.getName())) {
                         portMapping.setName(portMapping.getProtocol() + "-" + portMapping.getPort());
    -                    if(log.isInfoEnabled()) {
    +                    if (log.isInfoEnabled()) {
    --- End diff --
    
    Seems you have fixed only formatting issue here. Anyway, default carbon log level is set to "INFO", hence checking isInfoEnabled() introduce additional cost if it's same with org.apache.stratos too. Better check it and remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---