[GitHub] [solr-operator] huijieliu commented on a diff in pull request #451: Ability to customize default initContainer resources

[GitBox <gi...@apache.org>]

huijieliu commented on code in PR #451:
URL: https://github.com/apache/solr-operator/pull/451#discussion_r915294179


##########
controllers/util/solr_util.go:
##########
@@ -607,12 +615,20 @@ func generateSolrSetupInitContainers(solrCloud *solr.SolrCloud, solrCloudStatus
 		}
 	}
 
+	volumePrepResources := corev1.ResourceList{
+		corev1.ResourceCPU:    *DefaultSolrVolumePrepInitContainerCPU,

Review Comment:
   👏This will help to make sure if we configure our solr resources with limit=request as well,  the pod will get assigned with QoS class Guaranteed



##########
helm/solr/templates/_custom_option_helpers.tpl:
##########
@@ -98,6 +98,10 @@ initContainers:
 topologySpreadConstraints:
   {{- toYaml .Values.podOptions.topologySpreadConstraints | nindent 2 }}
 {{ end }}
+{{- if .Values.podOptions.defaultInitContainerResources -}}
+defaultInitContainerResources:

Review Comment:
   discussed offline, using default resource to configure both init container resource should be good for now if we need to custom init container resources as both are light weight init containers. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org