[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5074: HDFS-16819. Remove the redundant write lock in FsDatasetImpl#createTemporary

[GitBox <gi...@apache.org>]

haiyang1987 commented on code in PR #5074:
URL: https://github.com/apache/hadoop/pull/5074#discussion_r1006351748


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -1912,9 +1908,8 @@ public ReplicaHandler createTemporary(StorageType storageType,
       return new ReplicaHandler(newReplicaInfo, ref);
     } finally {
       if (dataNodeMetrics != null) {
-        // Create temporary operation hold write lock twice.
-        long createTemporaryOpMs = Time.monotonicNow() - startHoldLockTimeMs
-            + holdLockTimeMs;
+        // Create temporary operation hold write lock once.
+        long createTemporaryOpMs = Time.monotonicNow() - startHoldLockTimeMs;

Review Comment:
   @tomscut thanks for the help review.
   
   Update PR, Please help review again.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org