[GitHub] bjustin-ibm commented on a change in pull request #209: exponential backoff on trigger fire retry

[gi...@git.apache.org]

bjustin-ibm commented on a change in pull request #209: exponential backoff on trigger fire retry
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209#discussion_r131238589
 
 

 ##########
 File path: provider/thedoctor.py
 ##########
 @@ -27,7 +27,8 @@
 
 class TheDoctor (Thread):
     # maximum time to allow a consumer to not successfully poll() before restarting
-    poll_timeout_seconds = 20
+    # this value must be greater than the total amount of time a consumer might retry firing a trigger
+    poll_timeout_seconds = 200
 
 Review comment:
   This is the maximum amount of time between successful polls before the doctor will forcibly restart the consumer. It is a drastic measure that should not happen unless absolutely necessary. Keep in mind that previously, the total retry time was only 10 seconds and the `poll_timeout_seconds` was double that.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services