You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/02 22:14:03 UTC
[GitHub] [kafka] chia7712 opened a new pull request #10963: KAFKA-13030 FindCoordinators batching causes slow poll when requestin…
chia7712 opened a new pull request #10963:
URL: https://github.com/apache/kafka/pull/10963
issue: https://issues.apache.org/jira/browse/KAFKA-13030
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java#L888
```java
if (e instanceof NoBatchedFindCoordinatorsException) {
batchFindCoordinator = false;
clearFindCoordinatorFuture();
lookupCoordinator();
return;
}
```
The current request future is NOT updated so it can't be completed until timeout. It causes a slow poll when user poll data from older broker the first time.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #10963: KAFKA-13030 FindCoordinators batching causes slow poll when requestin…
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #10963:
URL: https://github.com/apache/kafka/pull/10963#issuecomment-873583155
Thanks @chia7712. This `if` statement is being removed in https://github.com/apache/kafka/pull/10965 so I think it should address this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10963: KAFKA-13030 FindCoordinators batching causes slow poll when requestin…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10963:
URL: https://github.com/apache/kafka/pull/10963#issuecomment-873593708
> This if statement is being removed in #10965 so I think it should address this issue
you are right. close this as duplicate :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10963: KAFKA-13030 FindCoordinators batching causes slow poll when requestin…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10963:
URL: https://github.com/apache/kafka/pull/10963#issuecomment-873521946
> nice find! Could we add tests for it?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 closed pull request #10963: KAFKA-13030 FindCoordinators batching causes slow poll when requestin…
Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #10963:
URL: https://github.com/apache/kafka/pull/10963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org