You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "njnu-seafish (via GitHub)" <gi...@apache.org> on 2026/04/14 12:30:39 UTC

[PR] [Improvement-18056] Clean up unused methods and classes in the dolphinscheduler-task-executor and dolphinscheduler-task-plugin [dolphinscheduler]

njnu-seafish opened a new pull request, #18172:
URL: https://github.com/apache/dolphinscheduler/pull/18172

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Was this PR generated or assisted by AI?
   
   NO
   
   ## Purpose of the pull request
   
   Part of https://github.com/apache/dolphinscheduler/issues/18056
   
   ## Brief change log
   
   Clean up unused methods and classes in the dolphinscheduler-task-executor and dolphinscheduler-task-plugin
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   ## Pull Request Notice
   [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-18056] Clean up unused methods and classes in the dolphinscheduler-task-executor and dolphinscheduler-task-plugin [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun closed pull request #18172: [Improvement-18056] Clean up unused methods and classes in the dolphinscheduler-task-executor and dolphinscheduler-task-plugin
URL: https://github.com/apache/dolphinscheduler/pull/18172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-18056] Clean up unused methods and classes in the dolphinscheduler-task-executor and dolphinscheduler-task-plugin [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #18172:
URL: https://github.com/apache/dolphinscheduler/pull/18172#discussion_r3151104742


##########
dolphinscheduler-task-executor/src/main/java/org/apache/dolphinscheduler/task/executor/exceptions/TaskExecutorRuntimeException.java:
##########
@@ -23,8 +23,4 @@ public TaskExecutorRuntimeException(String message) {
         super(message);
     }
 
-    public TaskExecutorRuntimeException(String message, Throwable cause) {

Review Comment:
   Keep this constructor.



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-aliyunserverlessspark/src/main/java/org/apache/dolphinscheduler/plugin/task/aliyunserverlessspark/AliyunServerlessSparkTaskException.java:
##########
@@ -19,10 +19,6 @@
 
 public class AliyunServerlessSparkTaskException extends RuntimeException {
 
-    public AliyunServerlessSparkTaskException() {

Review Comment:
   Keep this constructor.



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/KubernetesApplicationManager.java:
##########
@@ -51,7 +51,6 @@
 public class KubernetesApplicationManager implements ApplicationManager<KubernetesApplicationManagerContext> {
 
     private static final String PENDING = "Pending";
-    private static final String RUNNING = "Running";

Review Comment:
   Keep this state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org