You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/03/24 08:33:41 UTC
[GitHub] [incubator-pekko-projection] mdedetrich opened a new pull request, #14: Add github scalafmt check
mdedetrich opened a new pull request, #14:
URL: https://github.com/apache/incubator-pekko-projection/pull/14
Add scalafmt github check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-projection] pjfanning commented on a diff in pull request #14: Add github scalafmt check
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-projection/pull/14#discussion_r1147380787
##########
.github/workflows/format.yml:
##########
@@ -0,0 +1,25 @@
+name: Scalafmt
+
+permissions: read-all
Review Comment:
could you use `{}`
##########
.github/workflows/format.yml:
##########
@@ -0,0 +1,25 @@
+name: Scalafmt
+
+permissions: read-all
Review Comment:
could you use `{}` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-projection] mdedetrich merged pull request #14: Add github scalafmt check
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #14:
URL: https://github.com/apache/incubator-pekko-projection/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-projection] mdedetrich commented on a diff in pull request #14: Add github scalafmt check
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-projection/pull/14#discussion_r1147383084
##########
.github/workflows/format.yml:
##########
@@ -0,0 +1,25 @@
+name: Scalafmt
+
+permissions: read-all
Review Comment:
Done, I should really fix this in pekko-http because thats where I am copying this file from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org