[GitHub] [couchdb] nickva commented on pull request #4089: Migrate CouchDB to rebar3

[GitBox <gi...@apache.org>]

nickva commented on PR #4089:
URL: https://github.com/apache/couchdb/pull/4089#issuecomment-1185663418

   @jiahuili430 quite impressive, well done!
   
   I wonder if it would make it easier to review if we could extract some the changes into a preliminary PR so to speak. Basically any fixes up or whitespace changes or eunit fixups that would make sense even without switching to rebar3.
   
   Some examples could be:
      * app dependency updates like adding the `couch_tests`, 'config' dependencies to `*.app.src` files
      * Updating descriptions in app.src files
      * removing `crypto` from `couch_epi` app.src.script
      * some whitespace changes to `httpd_global_handlers`
      * `test_util:stop_applications([config, couch_log]).`
      * `application:ensure_started(couch_epi).`
   
   So then with those changes out of the way, and everything working as is, we'd have a second PR more focused on just switching from src to apps. What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org