[GitHub] [arrow] mcassels commented on a change in pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

[GitBox <gi...@apache.org>]

mcassels commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r434833711



##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -518,11 +518,12 @@ pub(crate) fn get_fb_field_type<'a: 'b, 'b>(
             )
         }
         List(ref list_type) => {
+            let field_name = fbb.create_string("list"); // field schema requires name to be not None

Review comment:
       As I understand it this field name is not actually going to be used. Here, List fields are being treated like a Struct containing a single field whose children are each of the items in the list. This dummy "list" name is being used as the name for the single child field, not as the name for the List field itself. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org