[GitHub] dsanders11 opened a new pull request #1559: Properly iterate modules looking for gzip commands

[GitBox <gi...@apache.org>]

dsanders11 opened a new pull request #1559: Properly iterate modules looking for gzip commands
URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559
 
 
   This change may or may not be needed. I spent a frustratingly long time trying to get gzip working with `ngx_pagespeed` in production, as I kept getting getting the `gzip command not found` error. I eventually got it working, and thought this change was the key, but I tried excluding it and my setup still worked, so now I'm not sure. During the journey of trying to get things working I changed to NGINX 1.14.0 as well as built `ngx_pagespeed` from a git checkout (so I could build up my own fork), so multiple things changed along the way. I unfortunately don't have the time to do a full test of changing a single variable at a time to find what really fixed my issues.
   
   That said, NGINX does [list this change](https://www.nginx.com/blog/nginx-dynamic-modules-how-they-work/#ngxToCycle) as the "proper" way to iterate modules when writing a dynamic module. It's not mentioned, but presumably this doesn't interfere with building as a static module.
   
   @oschaaf, perhaps you can take a look at the change and make a judgement call. I do believe there's a screw loose somewhere with gzip support (I was definitely getting `gzip command not found` with NGINX 1.12.2 and `ngx_pagespeed` v1.13.35.2-stable despite the gzip module being included, confirmed multiple times over), and this may be it. In theory even if this isn't it, this change should be "harmless".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services