You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/01/31 01:42:34 UTC

Review Request 17569: Added free and total memory to /system/stats.json.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17569/
-----------------------------------------------------------

Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-581
    https://issues.apache.org/jira/browse/MESOS-581


Repository: mesos-git


Description
-------

This patch expose the number bytes of total and free memory in the /system/stats.json.


Diffs
-----

  3rdparty/libprocess/include/process/system.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/17569/diff/


Testing
-------

make check and functional testing.


Thanks,

Niklas Nielsen


Re: Review Request 17569: Added free and total memory to /system/stats.json.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17569/#review33413
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On Jan. 30, 2014, 4:42 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17569/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 4:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose the number bytes of total and free memory in the /system/stats.json.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/system.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17569/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 17569: Added free and total memory to /system/stats.json.

Posted by Niklas Nielsen <ni...@qni.dk>.

> On Feb. 3, 2014, 10:30 a.m., Ben Mahler wrote:
> > Ship It!

Cool - thanks for reviewing! Mind taking a 2nd look at r17325 so we can land this? :)


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17569/#review33451
-----------------------------------------------------------


On Jan. 30, 2014, 4:42 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17569/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 4:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose the number bytes of total and free memory in the /system/stats.json.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/system.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17569/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 17569: Added free and total memory to /system/stats.json.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17569/#review33451
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Jan. 31, 2014, 12:42 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17569/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 12:42 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose the number bytes of total and free memory in the /system/stats.json.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/system.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17569/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>