You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/14 00:54:33 UTC

[GitHub] [kafka] wicknicks opened a new pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

wicknicks opened a new pull request #9015:
URL: https://github.com/apache/kafka/pull/9015


   Signed-off-by: Arjun Satish <ar...@confluent.io>
   
   If we call Exit.exit with code=0, the current implementation will go into an infinite recursion and kill the VM with a stack overflow error. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] wicknicks commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

Posted by GitBox <gi...@apache.org>.
wicknicks commented on pull request #9015:
URL: https://github.com/apache/kafka/pull/9015#issuecomment-657904326


   @kkonstantine @lbradstreet any thoughts on this PR? thanks in advance!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lbradstreet commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

Posted by GitBox <gi...@apache.org>.
lbradstreet commented on pull request #9015:
URL: https://github.com/apache/kafka/pull/9015#issuecomment-657966251


   Looks good, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kkonstantine commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #9015:
URL: https://github.com/apache/kafka/pull/9015#issuecomment-657959248


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] wicknicks commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

Posted by GitBox <gi...@apache.org>.
wicknicks commented on pull request #9015:
URL: https://github.com/apache/kafka/pull/9015#issuecomment-658402598


   thanks a lot, @kkonstantine!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kkonstantine commented on pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #9015:
URL: https://github.com/apache/kafka/pull/9015#issuecomment-658353712


   1 green build and only flaky test failures in the 2 others, so we are good to go here. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kkonstantine merged pull request #9015: MINOR: Remove call to Exit.exit() to prevent infinite recursion

Posted by GitBox <gi...@apache.org>.
kkonstantine merged pull request #9015:
URL: https://github.com/apache/kafka/pull/9015


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org