You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/19 17:26:39 UTC

[GitHub] [iceberg] kbendick opened a new pull request #3931: Flink - Fix flaky test in TestIcebergConnector that depends on select ordering

kbendick opened a new pull request #3931:
URL: https://github.com/apache/iceberg/pull/3931


   I noticed this test failure in another PR.
   
   It seems that this test depends on the ordering of the output rows, but we're really just testing `CREATE TABLE STATEMENTS` and ensuring various inserts work.
   
   Since some of these tests are for streaming, I might have to change this to set comparison (but all of them are insert statements without any ordering in the table):
   
   Here's the output stack trace from the failure where we can see that it's simply ordering:
   ```bash
   org.apache.iceberg.flink.TestIcebergConnector > testCreateTableUnderDefaultDatabase[catalogName = testhadoop, properties = {connector=iceberg, catalog-type=hadoop, catalog-table=not_existing_table}, isStreaming=true] FAILED
       java.lang.AssertionError: Should have expected rows expected:<[+I[1, AAA], +I[2, BBB], +I[3, CCC]]> but was:<[+I[2, BBB], +I[3, CCC], +I[1, AAA]]>
           at org.junit.Assert.fail(Assert.java:89)
           at org.junit.Assert.failNotEquals(Assert.java:835)
           at org.junit.Assert.assertEquals(Assert.java:120)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #3931: Flink: Fix flaky tests that depend on row order

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3931:
URL: https://github.com/apache/iceberg/pull/3931#issuecomment-1016778288


   Thanks, @kbendick!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue merged pull request #3931: Flink: Fix flaky tests that depend on row order

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3931:
URL: https://github.com/apache/iceberg/pull/3931


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org