You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/10 21:40:12 UTC
[GitHub] [arrow-datafusion] houqp opened a new pull request #704: replace once iter chain with array::IntoIter
houqp opened a new pull request #704:
URL: https://github.com/apache/arrow-datafusion/pull/704
# Rationale for this change
Follow up for #605.
# What changes are included in this PR?
Replace manual once chain iterator with array::IntoIter to make code more readable based on feedback from https://github.com/apache/arrow-datafusion/pull/605#discussion_r664543206.
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #704: replace once iter chain with array::IntoIter
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #704:
URL: https://github.com/apache/arrow-datafusion/pull/704#issuecomment-877979537
can you remove the intoiter wrapping since array has it implemented by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #704: replace once iter chain with array::IntoIter
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #704:
URL: https://github.com/apache/arrow-datafusion/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #704: replace once iter chain with array::IntoIter
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #704:
URL: https://github.com/apache/arrow-datafusion/pull/704#issuecomment-877836703
@jorgecarleitao yes, this is a relatively new API that landed in stable rust 1.51.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #704: replace once iter chain with array::IntoIter
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #704:
URL: https://github.com/apache/arrow-datafusion/pull/704#issuecomment-878814306
@Jimexist good call, I was using 1.52 on my dev machine, which was giving me errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org