[GitHub] [spark] zsxwing commented on a change in pull request #30521: [SPARK-33577][SS] Add support for V1Table in stream writer table API

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #30521:
URL: https://github.com/apache/spark/pull/30521#discussion_r532158522



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -304,46 +308,68 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
    * @since 3.1.0
    */
   @throws[TimeoutException]
-  def saveAsTable(tableName: String): StreamingQuery = {
-    this.source = SOURCE_NAME_TABLE
+  def table(tableName: String): StreamingQuery = {

Review comment:
       `saveAsTable` sounds weird to me since `DataStreamWriter` doesn't have a `save` method like `DataFrameWriter`.
   
   I prefer `DataStreamWriter.table` as it's consistent with `DataStreamReader.table`: `DataStreamReader.table` triggers `load` and `DataStreamWrite.table` triggers `start`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org