You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2016/10/18 21:24:46 UTC

[ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Hey

Recently, we decided to change the default bridge from using OnlineEvent to
a JS_Exec bridge so that we can support a multi-webview use case.  The
downside of this change is that it breaks on Crosswalk.  It's almost
impossible to debug this since projects that include the Crosswalk Webview
break Android Studio.

So, should we proceed with the release knowing that the bridge is broken on
Crosswalk, or should we delay and try to fix this? I do not want to revert
this bridge change back, since it's really important that we have a more
robust bridge than the ONLINE_EVENT bridge that only works with single
webview applications.

Does anyone have any thoughts on this?

Joe

RE: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by "Alexander Sorokin (Akvelon)" <v-...@microsoft.com>.
Sure, thanks for the clarification.

-----Original Message-----
From: Joe Bowser [mailto:bowserj@gmail.com] 
Sent: Monday, October 24, 2016 6:38 PM
To: dev <de...@cordova.apache.org>
Subject: Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Yes.  That is expected.  There should probably be an engine tag.  Crosswalk is it's own project, and it needs to figure out how it wants to handle prior releases of Cordova.  We can only do so much for it before moving on.

On Mon, Oct 24, 2016 at 3:59 AM, Alexander Sorokin (Akvelon) < v-alsoro@microsoft.com> wrote:

> Hey guys,
>
> Is it expected that after this bridge mode patch, crosswalk cannot be 
> built for cordova-android@<=5.2.2?
>
> Thanks,
> Alexander Sorokin
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Wednesday, October 19, 2016 2:39 AM
> To: dev@cordova.apache.org
> Subject: Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not 
> fire on Master
>
> Good work guys!
>
>
> On Tue, Oct 18, 2016 at 3:30 PM, Darryl Pogue <dv...@gmail.com> wrote:
>
> > I've opened a PR to add that bridge mode:
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> > hu
> > b.com%2Fcrosswalk-project%2Fcordova-plugin-&data=02%7C01%7Cv-alsoro%
> > 40 
> > microsoft.com%7Cad92e55ff3874529b07008d3f7b014a8%7C72f988bf86f141af9
> > 1a 
> > b2d7cd011db47%7C1%7C0%7C636124308052342233&sdata=Z87SlZo88DK5eIRzTR0
> > 9o
> > u3KtzbV8FgUl%2FkpsS4aRAQ%3D&reserved=0
> > crosswalk-webview/pull/100
> >
> > On 18 October 2016 at 15:23, Joe Bowser <bo...@gmail.com> wrote:
> > > BTW: I'd send a PR, but I still need Crosswalk to take over the 
> > > repo from me, since they're developing off a fork of my repo.
> > >
> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
> > > it 
> > > hub.com%2Fcrosswalk-project%2Fcordova-plugin-crosswalk-webview&dat
> > > a= 
> > > 02%7C01%7Cv-alsoro%40microsoft.com%7Cad92e55ff3874529b07008d3f7b01
> > > 4a 
> > > 8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636124308052342233&
> > > sd
> > > ata=kCF9YTv8kq6WGTD6MYuwtCuW7YIopqG%2BoHx6804EUlA%3D&reserved=0
> > >
> > >
> > >
> > > On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bo...@gmail.com> wrote:
> > >
> > >> Hey
> > >>
> > >> I just realized what the problem is:
> > >>
> > >> Crosswalk is missing this method, which adds the bridge mode, 
> > >> since the bridge mode defaults back ONLINE_EVENT in the event 
> > >> that EVAL_BRIDGE
> > isn't
> > >> supported, this will break every time.  We need the following 
> > >> line
> > added to
> > >> Crosswalk.
> > >>
> > >> nativeToJsMessageQueue.addBridgeMode(new
> > >> NativeToJsMessageQueue.EvalBridgeMode(this,
> > cordova));
> > >>
> > >>
> > >> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> > >>
> > >>> Correct.  Without that method, it won't even compile.
> > >>>
> > >>>
> > >>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue 
> > >>> <dv...@gmail.com>
> > >>> wrote:
> > >>>
> > >>>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
> > >>>> > Recently, we decided to change the default bridge from using
> > >>>> OnlineEvent to
> > >>>> > a JS_Exec bridge so that we can support a multi-webview use case.
> > The
> > >>>> > downside of this change is that it breaks on Crosswalk.  It's 
> > >>>> > almost impossible to debug this since projects that include 
> > >>>> > the Crosswalk
> > >>>> Webview
> > >>>> > break Android Studio.
> > >>>>
> > >>>> Just confirming, this is breaking on the latest version of 
> > >>>> Crosswalk
> > >>>> (2.1.0) that has the evaluateJavascript method added to the 
> > >>>> XWalkWebViewEngine class?
> > >>>>
> > >>>> ---------------------------------------------------------------
> > >>>> --
> > >>>> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>>>
> > >>>>
> > >>>
> > >>
> >
> > --------------------------------------------------------------------
> > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Joe Bowser <bo...@gmail.com>.
Yes.  That is expected.  There should probably be an engine tag.  Crosswalk
is it's own project, and it needs to figure out how it wants to handle
prior releases of Cordova.  We can only do so much for it before moving on.

On Mon, Oct 24, 2016 at 3:59 AM, Alexander Sorokin (Akvelon) <
v-alsoro@microsoft.com> wrote:

> Hey guys,
>
> Is it expected that after this bridge mode patch, crosswalk cannot be
> built for cordova-android@<=5.2.2?
>
> Thanks,
> Alexander Sorokin
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Wednesday, October 19, 2016 2:39 AM
> To: dev@cordova.apache.org
> Subject: Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not
> fire on Master
>
> Good work guys!
>
>
> On Tue, Oct 18, 2016 at 3:30 PM, Darryl Pogue <dv...@gmail.com> wrote:
>
> > I've opened a PR to add that bridge mode:
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> > b.com%2Fcrosswalk-project%2Fcordova-plugin-&data=02%7C01%7Cv-alsoro%40
> > microsoft.com%7Cad92e55ff3874529b07008d3f7b014a8%7C72f988bf86f141af91a
> > b2d7cd011db47%7C1%7C0%7C636124308052342233&sdata=Z87SlZo88DK5eIRzTR09o
> > u3KtzbV8FgUl%2FkpsS4aRAQ%3D&reserved=0
> > crosswalk-webview/pull/100
> >
> > On 18 October 2016 at 15:23, Joe Bowser <bo...@gmail.com> wrote:
> > > BTW: I'd send a PR, but I still need Crosswalk to take over the repo
> > > from me, since they're developing off a fork of my repo.
> > >
> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> > > hub.com%2Fcrosswalk-project%2Fcordova-plugin-crosswalk-webview&data=
> > > 02%7C01%7Cv-alsoro%40microsoft.com%7Cad92e55ff3874529b07008d3f7b014a
> > > 8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636124308052342233&sd
> > > ata=kCF9YTv8kq6WGTD6MYuwtCuW7YIopqG%2BoHx6804EUlA%3D&reserved=0
> > >
> > >
> > >
> > > On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bo...@gmail.com> wrote:
> > >
> > >> Hey
> > >>
> > >> I just realized what the problem is:
> > >>
> > >> Crosswalk is missing this method, which adds the bridge mode, since
> > >> the bridge mode defaults back ONLINE_EVENT in the event that
> > >> EVAL_BRIDGE
> > isn't
> > >> supported, this will break every time.  We need the following line
> > added to
> > >> Crosswalk.
> > >>
> > >> nativeToJsMessageQueue.addBridgeMode(new
> > >> NativeToJsMessageQueue.EvalBridgeMode(this,
> > cordova));
> > >>
> > >>
> > >> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> > >>
> > >>> Correct.  Without that method, it won't even compile.
> > >>>
> > >>>
> > >>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue
> > >>> <dv...@gmail.com>
> > >>> wrote:
> > >>>
> > >>>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
> > >>>> > Recently, we decided to change the default bridge from using
> > >>>> OnlineEvent to
> > >>>> > a JS_Exec bridge so that we can support a multi-webview use case.
> > The
> > >>>> > downside of this change is that it breaks on Crosswalk.  It's
> > >>>> > almost impossible to debug this since projects that include the
> > >>>> > Crosswalk
> > >>>> Webview
> > >>>> > break Android Studio.
> > >>>>
> > >>>> Just confirming, this is breaking on the latest version of
> > >>>> Crosswalk
> > >>>> (2.1.0) that has the evaluateJavascript method added to the
> > >>>> XWalkWebViewEngine class?
> > >>>>
> > >>>> -----------------------------------------------------------------
> > >>>> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>>>
> > >>>>
> > >>>
> > >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

RE: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by "Alexander Sorokin (Akvelon)" <v-...@microsoft.com>.
Hey guys,

Is it expected that after this bridge mode patch, crosswalk cannot be built for cordova-android@<=5.2.2?

Thanks,
Alexander Sorokin

-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com] 
Sent: Wednesday, October 19, 2016 2:39 AM
To: dev@cordova.apache.org
Subject: Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Good work guys!


On Tue, Oct 18, 2016 at 3:30 PM, Darryl Pogue <dv...@gmail.com> wrote:

> I've opened a PR to add that bridge mode:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fcrosswalk-project%2Fcordova-plugin-&data=02%7C01%7Cv-alsoro%40
> microsoft.com%7Cad92e55ff3874529b07008d3f7b014a8%7C72f988bf86f141af91a
> b2d7cd011db47%7C1%7C0%7C636124308052342233&sdata=Z87SlZo88DK5eIRzTR09o
> u3KtzbV8FgUl%2FkpsS4aRAQ%3D&reserved=0
> crosswalk-webview/pull/100
>
> On 18 October 2016 at 15:23, Joe Bowser <bo...@gmail.com> wrote:
> > BTW: I'd send a PR, but I still need Crosswalk to take over the repo 
> > from me, since they're developing off a fork of my repo.
> >
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> > hub.com%2Fcrosswalk-project%2Fcordova-plugin-crosswalk-webview&data=
> > 02%7C01%7Cv-alsoro%40microsoft.com%7Cad92e55ff3874529b07008d3f7b014a
> > 8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636124308052342233&sd
> > ata=kCF9YTv8kq6WGTD6MYuwtCuW7YIopqG%2BoHx6804EUlA%3D&reserved=0
> >
> >
> >
> > On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Hey
> >>
> >> I just realized what the problem is:
> >>
> >> Crosswalk is missing this method, which adds the bridge mode, since 
> >> the bridge mode defaults back ONLINE_EVENT in the event that 
> >> EVAL_BRIDGE
> isn't
> >> supported, this will break every time.  We need the following line
> added to
> >> Crosswalk.
> >>
> >> nativeToJsMessageQueue.addBridgeMode(new 
> >> NativeToJsMessageQueue.EvalBridgeMode(this,
> cordova));
> >>
> >>
> >> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>
> >>> Correct.  Without that method, it won't even compile.
> >>>
> >>>
> >>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue 
> >>> <dv...@gmail.com>
> >>> wrote:
> >>>
> >>>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
> >>>> > Recently, we decided to change the default bridge from using
> >>>> OnlineEvent to
> >>>> > a JS_Exec bridge so that we can support a multi-webview use case.
> The
> >>>> > downside of this change is that it breaks on Crosswalk.  It's 
> >>>> > almost impossible to debug this since projects that include the 
> >>>> > Crosswalk
> >>>> Webview
> >>>> > break Android Studio.
> >>>>
> >>>> Just confirming, this is breaking on the latest version of 
> >>>> Crosswalk
> >>>> (2.1.0) that has the evaluateJavascript method added to the 
> >>>> XWalkWebViewEngine class?
> >>>>
> >>>> -----------------------------------------------------------------
> >>>> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>>
> >>>>
> >>>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Steven Gill <st...@gmail.com>.
Good work guys!


On Tue, Oct 18, 2016 at 3:30 PM, Darryl Pogue <dv...@gmail.com> wrote:

> I've opened a PR to add that bridge mode:
> https://github.com/crosswalk-project/cordova-plugin-
> crosswalk-webview/pull/100
>
> On 18 October 2016 at 15:23, Joe Bowser <bo...@gmail.com> wrote:
> > BTW: I'd send a PR, but I still need Crosswalk to take over the repo from
> > me, since they're developing off a fork of my repo.
> >
> > https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview
> >
> >
> >
> > On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Hey
> >>
> >> I just realized what the problem is:
> >>
> >> Crosswalk is missing this method, which adds the bridge mode, since the
> >> bridge mode defaults back ONLINE_EVENT in the event that EVAL_BRIDGE
> isn't
> >> supported, this will break every time.  We need the following line
> added to
> >> Crosswalk.
> >>
> >> nativeToJsMessageQueue.addBridgeMode(new NativeToJsMessageQueue.EvalBridgeMode(this,
> cordova));
> >>
> >>
> >> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>
> >>> Correct.  Without that method, it won't even compile.
> >>>
> >>>
> >>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue <dv...@gmail.com>
> >>> wrote:
> >>>
> >>>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
> >>>> > Recently, we decided to change the default bridge from using
> >>>> OnlineEvent to
> >>>> > a JS_Exec bridge so that we can support a multi-webview use case.
> The
> >>>> > downside of this change is that it breaks on Crosswalk.  It's almost
> >>>> > impossible to debug this since projects that include the Crosswalk
> >>>> Webview
> >>>> > break Android Studio.
> >>>>
> >>>> Just confirming, this is breaking on the latest version of Crosswalk
> >>>> (2.1.0) that has the evaluateJavascript method added to the
> >>>> XWalkWebViewEngine class?
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>>
> >>>>
> >>>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Darryl Pogue <dv...@gmail.com>.
I've opened a PR to add that bridge mode:
https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview/pull/100

On 18 October 2016 at 15:23, Joe Bowser <bo...@gmail.com> wrote:
> BTW: I'd send a PR, but I still need Crosswalk to take over the repo from
> me, since they're developing off a fork of my repo.
>
> https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview
>
>
>
> On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Hey
>>
>> I just realized what the problem is:
>>
>> Crosswalk is missing this method, which adds the bridge mode, since the
>> bridge mode defaults back ONLINE_EVENT in the event that EVAL_BRIDGE isn't
>> supported, this will break every time.  We need the following line added to
>> Crosswalk.
>>
>> nativeToJsMessageQueue.addBridgeMode(new NativeToJsMessageQueue.EvalBridgeMode(this, cordova));
>>
>>
>> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> Correct.  Without that method, it won't even compile.
>>>
>>>
>>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue <dv...@gmail.com>
>>> wrote:
>>>
>>>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
>>>> > Recently, we decided to change the default bridge from using
>>>> OnlineEvent to
>>>> > a JS_Exec bridge so that we can support a multi-webview use case.  The
>>>> > downside of this change is that it breaks on Crosswalk.  It's almost
>>>> > impossible to debug this since projects that include the Crosswalk
>>>> Webview
>>>> > break Android Studio.
>>>>
>>>> Just confirming, this is breaking on the latest version of Crosswalk
>>>> (2.1.0) that has the evaluateJavascript method added to the
>>>> XWalkWebViewEngine class?
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>>>
>>>>
>>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Joe Bowser <bo...@gmail.com>.
BTW: I'd send a PR, but I still need Crosswalk to take over the repo from
me, since they're developing off a fork of my repo.

https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview



On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser <bo...@gmail.com> wrote:

> Hey
>
> I just realized what the problem is:
>
> Crosswalk is missing this method, which adds the bridge mode, since the
> bridge mode defaults back ONLINE_EVENT in the event that EVAL_BRIDGE isn't
> supported, this will break every time.  We need the following line added to
> Crosswalk.
>
> nativeToJsMessageQueue.addBridgeMode(new NativeToJsMessageQueue.EvalBridgeMode(this, cordova));
>
>
> On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Correct.  Without that method, it won't even compile.
>>
>>
>> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue <dv...@gmail.com>
>> wrote:
>>
>>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
>>> > Recently, we decided to change the default bridge from using
>>> OnlineEvent to
>>> > a JS_Exec bridge so that we can support a multi-webview use case.  The
>>> > downside of this change is that it breaks on Crosswalk.  It's almost
>>> > impossible to debug this since projects that include the Crosswalk
>>> Webview
>>> > break Android Studio.
>>>
>>> Just confirming, this is breaking on the latest version of Crosswalk
>>> (2.1.0) that has the evaluateJavascript method added to the
>>> XWalkWebViewEngine class?
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>>
>>>
>>
>

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Joe Bowser <bo...@gmail.com>.
Hey

I just realized what the problem is:

Crosswalk is missing this method, which adds the bridge mode, since the
bridge mode defaults back ONLINE_EVENT in the event that EVAL_BRIDGE isn't
supported, this will break every time.  We need the following line added to
Crosswalk.

nativeToJsMessageQueue.addBridgeMode(new
NativeToJsMessageQueue.EvalBridgeMode(this, cordova));


On Tue, Oct 18, 2016 at 2:32 PM, Joe Bowser <bo...@gmail.com> wrote:

> Correct.  Without that method, it won't even compile.
>
>
> On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue <dv...@gmail.com> wrote:
>
>> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
>> > Recently, we decided to change the default bridge from using
>> OnlineEvent to
>> > a JS_Exec bridge so that we can support a multi-webview use case.  The
>> > downside of this change is that it breaks on Crosswalk.  It's almost
>> > impossible to debug this since projects that include the Crosswalk
>> Webview
>> > break Android Studio.
>>
>> Just confirming, this is breaking on the latest version of Crosswalk
>> (2.1.0) that has the evaluateJavascript method added to the
>> XWalkWebViewEngine class?
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Joe Bowser <bo...@gmail.com>.
Correct.  Without that method, it won't even compile.

On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue <dv...@gmail.com> wrote:

> On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
> > Recently, we decided to change the default bridge from using OnlineEvent
> to
> > a JS_Exec bridge so that we can support a multi-webview use case.  The
> > downside of this change is that it breaks on Crosswalk.  It's almost
> > impossible to debug this since projects that include the Crosswalk
> Webview
> > break Android Studio.
>
> Just confirming, this is breaking on the latest version of Crosswalk
> (2.1.0) that has the evaluateJavascript method added to the
> XWalkWebViewEngine class?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

Posted by Darryl Pogue <dv...@gmail.com>.
On 18 October 2016 at 14:24, Joe Bowser <bo...@gmail.com> wrote:
> Recently, we decided to change the default bridge from using OnlineEvent to
> a JS_Exec bridge so that we can support a multi-webview use case.  The
> downside of this change is that it breaks on Crosswalk.  It's almost
> impossible to debug this since projects that include the Crosswalk Webview
> break Android Studio.

Just confirming, this is breaking on the latest version of Crosswalk
(2.1.0) that has the evaluateJavascript method added to the
XWalkWebViewEngine class?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org