You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/02/21 05:19:47 UTC

Change in asterixdb[master]: Fixed CreatePointDescriptor

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/650

Change subject: Fixed CreatePointDescriptor
......................................................................

Fixed CreatePointDescriptor

 - Fixed a typo in CreatePointDescriptor.

Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
---
M asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/50/650/1

diff --git a/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java b/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
index d0a6564..b65c5c0 100644
--- a/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
+++ b/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
@@ -83,7 +83,7 @@
                         byte[] bytes0 = inputArg0.getByteArray();
                         int offset0 = inputArg0.getStartOffset();
                         byte[] bytes1 = inputArg1.getByteArray();
-                        int offset1 = inputArg0.getStartOffset();
+                        int offset1 = inputArg1.getStartOffset();
 
                         // type-check: (double, double)
                         if ((bytes0[offset0] != ATypeTag.SERIALIZED_DOUBLE_TYPE_TAG

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/650
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>

Change in asterixdb[master]: Fixed CreatePointDescriptor

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Fixed CreatePointDescriptor
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/855/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/650
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Young-Seok Kim <ki...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed CreatePointDescriptor

Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has submitted this change and it was merged.

Change subject: Fixed CreatePointDescriptor
......................................................................


Fixed CreatePointDescriptor

 - Fixed a typo in CreatePointDescriptor.

Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/650
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Young-Seok Kim <ki...@gmail.com>
---
M asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Young-Seok Kim: Looks good to me, approved
  Jenkins: Verified



diff --git a/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java b/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
index d0a6564..b65c5c0 100644
--- a/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
+++ b/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePointDescriptor.java
@@ -83,7 +83,7 @@
                         byte[] bytes0 = inputArg0.getByteArray();
                         int offset0 = inputArg0.getStartOffset();
                         byte[] bytes1 = inputArg1.getByteArray();
-                        int offset1 = inputArg0.getStartOffset();
+                        int offset1 = inputArg1.getStartOffset();
 
                         // type-check: (double, double)
                         if ((bytes0[offset0] != ATypeTag.SERIALIZED_DOUBLE_TYPE_TAG

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/650
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Young-Seok Kim <ki...@gmail.com>

Change in asterixdb[master]: Fixed CreatePointDescriptor

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Fixed CreatePointDescriptor
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/855/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/650
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed CreatePointDescriptor

Posted by "Young-Seok Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Young-Seok Kim has posted comments on this change.

Change subject: Fixed CreatePointDescriptor
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/650
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2529e8cbdaf6d14b03dd27de9d8c0f8afa451f4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Young-Seok Kim <ki...@gmail.com>
Gerrit-HasComments: No