You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/26 03:21:02 UTC
[GitHub] [hive] ChangjiGuo opened a new pull request #2024: HIVE-24834 support submit comment for kafka table
ChangjiGuo opened a new pull request #2024:
URL: https://github.com/apache/hive/pull/2024
When using kafka-handler to create a kafka table, no matter whether the user specifies column comment or not, the comment will become 'from deserializer' when the 'show create table' command is used to view the table structure.
It is worth noting that I am not very familiar with hive. Can someone help me review whether the modification of HiveMetaStoreUtils.java has any side effects?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ChangjiGuo commented on a change in pull request #2024: HIVE-24834 support submit comment for kafka table
Posted by GitBox <gi...@apache.org>.
ChangjiGuo commented on a change in pull request #2024:
URL: https://github.com/apache/hive/pull/2024#discussion_r583522422
##########
File path: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java
##########
@@ -201,7 +201,7 @@ static public Deserializer getDeserializer(Configuration conf,
private static final String FROM_SERIALIZER = "from deserializer";
private static String determineFieldComment(String comment) {
- return (comment == null) ? FROM_SERIALIZER : comment;
+ return ("".equals(comment)) ? null : comment;
Review comment:
I think we should not specify a value if the comment is null, so I modified the unit test.
Is my understanding right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ChangjiGuo commented on a change in pull request #2024: HIVE-24834 support submit comment for kafka table
Posted by GitBox <gi...@apache.org>.
ChangjiGuo commented on a change in pull request #2024:
URL: https://github.com/apache/hive/pull/2024#discussion_r583522422
##########
File path: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java
##########
@@ -201,7 +201,7 @@ static public Deserializer getDeserializer(Configuration conf,
private static final String FROM_SERIALIZER = "from deserializer";
private static String determineFieldComment(String comment) {
- return (comment == null) ? FROM_SERIALIZER : comment;
+ return ("".equals(comment)) ? null : comment;
Review comment:
I think we should not specify a value if the comment is null, so I modified the integration test.
Is my understanding right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ChangjiGuo closed pull request #2024: HIVE-24834 support submit comment for kafka table
Posted by GitBox <gi...@apache.org>.
ChangjiGuo closed pull request #2024:
URL: https://github.com/apache/hive/pull/2024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org