[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

["stack (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Attachment: hadoop1420.patch

Patch attached.  Below is commit message.

HADOOP-1420. Fix findbugs 'bad practise', 'dodgy', and 'correctness' bugs.
Removed all but one of the 'performance', and some of the 
'multithreaded correctness' (complaints about starting threads
in constructor, notifies with no apparent waiter, and
synchronization that doesn't completely cover member access remain).
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLogKey.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreFile.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/Leases.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreKey.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HTableDescriptor.java
    (equals, hashCode): Added.
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegionServer.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HClient.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLog.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HMemcache.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegiondirReader.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HAbstractScanner.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java
    All above had one or more of below applied:
    Use autoboxing of Integer and use Map.Entry rather than 
    Map.keySet and then a Map.get(key)  (performance).
    Remove synchronization around Thread.sleep.
    Make inner class w/ no references to hosting class static.
    Make inner class w/ no references to hosting class static.
    Use autoboxing of Integer and use Map.Entry rather than 
    Map.keySet and then a Map.get(key)  (performance).
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HServerAddress.java
    Remove odd wrapping of constructed strings in 'new String'.
    Use Map.Entry rather than Map.keySet and then a Map.get(key) 
    (performance).

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.